Re: [patch 2/3] mm: fault vs invalidate/truncate race fix

Andrew Morton
2006-10-07T20:44:10Z

On Sat, 7 Oct 2006 15:06:21 +0200 (CEST)
Nick Piggin <npiggin@suse.de> wrote:

> Fix the race between invalidate_inode_pages and do_no_page.

- In do_no_page() there's a `goto retry' where we appear to have
forgotten to (conditionally) unlock the page.

- In do_no_page() the COW-break code seem to have forgotten to
(conditionally) unlock the page which it just COWed?

- In do_no_page(), the unlock_page() which _is_ there doesn't test
VM_CAN_INVALIDATE before deciding to unlock the page.

I have a bad feeling that I'm not getting the point here...

<looks>

Ah, it appears you've fixed at least some of these things in the next
patch. Tricky.