* [2.6 patch] HT_IRQ must depend on PCI
@ 2006-10-08 4:06 Adrian Bunk
2006-10-08 13:00 ` Eric W. Biederman
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-10-08 4:06 UTC (permalink / raw)
To: ebiederm; +Cc: linux-kernel, Jesper Juhl, gregkh, linux-pci
CONFIG_PCI=n, CONFIG_HT_IRQ=y results in the following compile error:
<-- snip -->
...
LD vmlinux
arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
summit.c:(.text+0x53): undefined reference to `apicid_2_node'
arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
(.text+0xcf79): undefined reference to `write_ht_irq_low'
arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
(.text+0xcf85): undefined reference to `write_ht_irq_high'
arch/i386/kernel/built-in.o: In function `k7nops':
alternative.c:(.data+0x1358): undefined reference to `mask_ht_irq'
alternative.c:(.data+0x1360): undefined reference to `unmask_ht_irq'
make[1]: *** [vmlinux] Error 1
<-- snip -->
Bug report by Jesper Juhl.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6/drivers/pci/Kconfig.old 2006-10-08 05:55:51.000000000 +0200
+++ linux-2.6/drivers/pci/Kconfig 2006-10-08 05:56:14.000000000 +0200
@@ -55,7 +55,7 @@
config HT_IRQ
bool "Interrupts on hypertransport devices"
default y
- depends on X86_LOCAL_APIC && X86_IO_APIC
+ depends on PCI && X86_LOCAL_APIC && X86_IO_APIC
help
This allows native hypertransport devices to use interrupts.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] HT_IRQ must depend on PCI
2006-10-08 4:06 [2.6 patch] HT_IRQ must depend on PCI Adrian Bunk
@ 2006-10-08 13:00 ` Eric W. Biederman
0 siblings, 0 replies; 2+ messages in thread
From: Eric W. Biederman @ 2006-10-08 13:00 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel, Jesper Juhl, gregkh, linux-pci
Adrian Bunk <bunk@stusta.de> writes:
Looks good to me.
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
> CONFIG_PCI=n, CONFIG_HT_IRQ=y results in the following compile error:
>
> <-- snip -->
>
> ...
> LD vmlinux
> arch/i386/mach-generic/built-in.o: In function `apicid_to_node':
> summit.c:(.text+0x53): undefined reference to `apicid_2_node'
> arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
> (.text+0xcf79): undefined reference to `write_ht_irq_low'
> arch/i386/kernel/built-in.o: In function `arch_setup_ht_irq':
> (.text+0xcf85): undefined reference to `write_ht_irq_high'
> arch/i386/kernel/built-in.o: In function `k7nops':
> alternative.c:(.data+0x1358): undefined reference to `mask_ht_irq'
> alternative.c:(.data+0x1360): undefined reference to `unmask_ht_irq'
> make[1]: *** [vmlinux] Error 1
>
> <-- snip -->
>
> Bug report by Jesper Juhl.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6/drivers/pci/Kconfig.old 2006-10-08 05:55:51.000000000 +0200
> +++ linux-2.6/drivers/pci/Kconfig 2006-10-08 05:56:14.000000000 +0200
> @@ -55,7 +55,7 @@
> config HT_IRQ
> bool "Interrupts on hypertransport devices"
> default y
> - depends on X86_LOCAL_APIC && X86_IO_APIC
> + depends on PCI && X86_LOCAL_APIC && X86_IO_APIC
> help
> This allows native hypertransport devices to use interrupts.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-08 13:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-08 4:06 [2.6 patch] HT_IRQ must depend on PCI Adrian Bunk
2006-10-08 13:00 ` Eric W. Biederman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox