[patch] pull in linux/types.h in linux/nbd.h

[patch] pull in linux/types.h in linux/nbd.h

[Mike Frysinger]

[-- Attachment #1.1: Type: text/plain, Size: 153 bytes --]

the nbd header uses __be32 and such types but doesnt actually include the 
header that defines these things (linux/types.h); so lets include it
-mike

[-- Attachment #1.2: Type: application/pgp-signature, Size: 827 bytes --]

[-- Attachment #2: nbd-needs-linux-types.patch --]
[-- Type: text/x-diff, Size: 536 bytes --]

the nbd header uses __be32 and such types but doesnt actually include the
header that defines these things (linux/types.h); so lets include it

Signed-off-by: Mike Frysinger <vapier@gentoo.org>

diff --git a/include/linux/nbd.h b/include/linux/nbd.h
index e712e7d..d6b6dc0 100644
--- a/include/linux/nbd.h
+++ b/include/linux/nbd.h
@@ -15,6 +15,8 @@
 #ifndef LINUX_NBD_H
 #define LINUX_NBD_H
 
+#include <linux/types.h>
+
 #define NBD_SET_SOCK	_IO( 0xab, 0 )
 #define NBD_SET_BLKSIZE	_IO( 0xab, 1 )
 #define NBD_SET_SIZE	_IO( 0xab, 2 )

Re: [patch] pull in linux/types.h in linux/nbd.h

[Jan Engelhardt]

>
>the nbd header uses __be32 and such types but doesnt actually include the 
>header that defines these things (linux/types.h); so lets include it
>-mike

Hm, <linux/cdev.h> uses struct kobject and should therefore include 
<linux/kobejct.h>, can  you make a patch for that too? Thanks.


	-`J'
-- 

Re: [patch] pull in linux/types.h in linux/nbd.h

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 492 bytes --]

On Monday 09 October 2006 03:12, Jan Engelhardt wrote:
> >the nbd header uses __be32 and such types but doesnt actually include the
> >header that defines these things (linux/types.h); so lets include it
>
> Hm, <linux/cdev.h> uses struct kobject and should therefore include
> <linux/kobejct.h>, can  you make a patch for that too? Thanks.

linux/cdev.h isnt exported to userspace so i dont really care about it ... if 
you do, feel free to write the patch yourself. Thanks.
-mike

[-- Attachment #2: Type: application/pgp-signature, Size: 827 bytes --]

[PATCH] pull in necessary header files for cdev.h

[Jan Engelhardt]

linux/cdev.h uses struct kobject and other structs and should 
therefore include them. Currently, a module either needs to add the 
missing includes itself, or, in case a module includes other headers 
already, needs to put <linux/cdev.h> last, which goes against a 
alphabetically-sorted include list.

Signed-off-by: Jan Engelhardt <jengelh@gmx.de>

Index: linux-2.6.19-rc2/include/linux/cdev.h
===================================================================
--- linux-2.6.19-rc2.orig/include/linux/cdev.h
+++ linux-2.6.19-rc2/include/linux/cdev.h
@@ -2,6 +2,10 @@
 #define _LINUX_CDEV_H
 #ifdef __KERNEL__
 
+#include <linux/kobject.h>
+#include <linux/kdev_t.h>
+#include <linux/list.h>
+
 struct cdev {
 	struct kobject kobj;
 	struct module *owner;
#<EOF>

	-`J'
--