From: Al Viro <viro@ftp.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>
Cc: Matthew Wilcox <matthew@wil.cx>,
Linus Torvalds <torvalds@osdl.org>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@parisc-linux.org>
Subject: Re: [PATCH] Consolidate check_signature
Date: Sun, 8 Oct 2006 21:24:24 +0100 [thread overview]
Message-ID: <20061008202423.GC29920@ftp.linux.org.uk> (raw)
In-Reply-To: <20061008132147.958dc6a8.akpm@osdl.org>
On Sun, Oct 08, 2006 at 01:21:47PM -0700, Andrew Morton wrote:
> On Thu, 05 Oct 2006 11:05:55 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
>
> > There's nothing arch-specific about check_signature(), so move it to
> > <linux/io.h>. Use a cross between the Alpha and i386 implementations
> > as the generic one.
>
> It wuld have been nice to have uninlined it too. And to have given
> it a less crappy name.
memcmp_withio(), to follow the general style?
next prev parent reply other threads:[~2006-10-08 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 17:05 [PATCH] Use linux/io.h instead of asm/io.h Matthew Wilcox
2006-10-05 17:05 ` [PATCH] Consolidate check_signature Matthew Wilcox
2006-10-05 17:20 ` Jeff Garzik
2006-10-05 22:03 ` Alan Cox
2006-10-08 20:21 ` Andrew Morton
2006-10-08 20:24 ` Al Viro [this message]
2006-10-05 17:19 ` [PATCH] Use linux/io.h instead of asm/io.h Jeff Garzik
2006-10-05 17:26 ` Matthew Wilcox
2006-10-05 22:04 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061008202423.GC29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
--cc=willy@parisc-linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox