public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Aneesh Kumar <aneesh.kumar@gmail.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] lockdep-design.txt
Date: Mon, 9 Oct 2006 08:53:08 +0200	[thread overview]
Message-ID: <20061009065308.GA5577@elte.hu> (raw)
In-Reply-To: <cc723f590610060244x45d482b3v9a645bc1406ae21a@mail.gmail.com>


* Aneesh Kumar <aneesh.kumar@gmail.com> wrote:

> I was looking at lockdep-desing.txt and i guess i am confused with the 
> changes with respect to fd7bcea35e7efb108c34ee2b3840942a3749cadb. It 
> says
> 
> +   '.'  acquired while irqs enabled
> +   '+'  acquired in irq context
> +   '-'  acquired in process context with irqs disabled
> +   '?'  read-acquired both with irqs enabled and in irq context
> +
> 
> 
> But the get_usage_chars() function does this for '-'
> if (class->usage_mask & LOCKF_ENABLED_HARDIRQS)
>                        *c1 = '-';
> 
> 
> 
> So i guess what would be correct would be
> '.'  acquired while irqs disabled
> '+'  acquired in irq context
> '-'  acquired with irqs enabled
> '?' read acquired in irq context with irqs enabled.
> 
> Is this correct ?

indeed, that's correct.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

      reply	other threads:[~2006-10-09  7:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cc723f590610050859l11cdf15cmbfad829872d086e4@mail.gmail.com>
2006-10-06  9:44 ` [PATCH] lockdep-design.txt Aneesh Kumar
2006-10-09  6:53   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061009065308.GA5577@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=aneesh.kumar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox