[PATCH] lockdep-design.txt

[PATCH] lockdep-design.txt

[Aneesh Kumar]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Hi Ingo,

I was looking at lockdep-desing.txt and i guess i am confused with the
changes with respect to fd7bcea35e7efb108c34ee2b3840942a3749cadb. It
says

+   '.'  acquired while irqs enabled
+   '+'  acquired in irq context
+   '-'  acquired in process context with irqs disabled
+   '?'  read-acquired both with irqs enabled and in irq context
+


But the get_usage_chars() function does this for '-'
 if (class->usage_mask & LOCKF_ENABLED_HARDIRQS)
                        *c1 = '-';



So i guess what would be correct would be
'.'  acquired while irqs disabled
'+'  acquired in irq context
'-'  acquired with irqs enabled
'?' read acquired in irq context with irqs enabled.

Is this correct ?

-aneesh

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: lockdep-design.txt.diff --]
[-- Type: text/x-patch; name="lockdep-design.txt.diff", Size: 710 bytes --]

diff --git a/Documentation/lockdep-design.txt b/Documentation/lockdep-design.txt
index dab123d..4887730 100644
--- a/Documentation/lockdep-design.txt
+++ b/Documentation/lockdep-design.txt
@@ -50,10 +50,10 @@ The bit position indicates hardirq, soft
 softirq-read respectively, and the character displayed in each
 indicates:
 
-   '.'	 acquired while irqs enabled
+   '.'  acquired while irqs disabled
    '+'  acquired in irq context
-   '-'  acquired in process context with irqs disabled
-   '?'  read-acquired both with irqs enabled and in irq context
+   '-'  acquired with irqs enabled
+   '?' read acquired in irq context with irqs enabled.
 
 Unused mutexes cannot be part of the cause of an error.
 

Re: [PATCH] lockdep-design.txt

[Ingo Molnar]

* Aneesh Kumar <aneesh.kumar@gmail.com> wrote:

> I was looking at lockdep-desing.txt and i guess i am confused with the 
> changes with respect to fd7bcea35e7efb108c34ee2b3840942a3749cadb. It 
> says
> 
> +   '.'  acquired while irqs enabled
> +   '+'  acquired in irq context
> +   '-'  acquired in process context with irqs disabled
> +   '?'  read-acquired both with irqs enabled and in irq context
> +
> 
> 
> But the get_usage_chars() function does this for '-'
> if (class->usage_mask & LOCKF_ENABLED_HARDIRQS)
>                        *c1 = '-';
> 
> 
> 
> So i guess what would be correct would be
> '.'  acquired while irqs disabled
> '+'  acquired in irq context
> '-'  acquired with irqs enabled
> '?' read acquired in irq context with irqs enabled.
> 
> Is this correct ?

indeed, that's correct.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo