From: Timo Teras <timo.teras@solidboot.com>
To: Timo Teras <timo.teras@solidboot.com>,
drzeus-list@drzeus.cx, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MMC: Select only one voltage bit in OCR response
Date: Mon, 9 Oct 2006 20:23:50 +0300 [thread overview]
Message-ID: <20061009172350.GC1637@mail.solidboot.com> (raw)
In-Reply-To: <20061009165317.GA6431@flint.arm.linux.org.uk>
On Mon, Oct 09, 2006 at 05:53:17PM +0100, Russell King wrote:
> On Mon, Oct 09, 2006 at 06:00:44PM +0300, Timo Teras wrote:
> > The card might go to inactive state (according to specification), if
> > there are unsupported bits set in the OCR.
>
> NAK. This breaks some MMC cards.
I see. But if we do send an OCR with an unsupported bit set, the card will
go to inactive state and is unusable. This problem is masked on controllers
with only 3.3V support, but I'm working with a controller supporting several
different voltages.
For example, I have a card giving an OCR reply of 0x0ff80080. The current
code will reply to this with 0x00000180 which is clearly incorrect.
Maybe something like "ocr &= 3 << bit;" would be more approriate?
Cheers,
Timo
next prev parent reply other threads:[~2006-10-09 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-09 15:00 [PATCH] MMC: Select only one voltage bit in OCR response Timo Teras
2006-10-09 16:53 ` Russell King
2006-10-09 17:23 ` Timo Teras [this message]
2006-10-16 6:34 ` Pierre Ossman
2006-10-22 9:25 ` Pierre Ossman
2006-10-31 10:05 ` Russell King
2006-10-31 15:24 ` Juha Yrjola
2006-11-02 18:37 ` Pierre Ossman
2006-10-10 13:23 ` [PATCH] MMC: Do not set unsupported bits " Timo Teras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061009172350.GC1637@mail.solidboot.com \
--to=timo.teras@solidboot.com \
--cc=drzeus-list@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox