From: Ingo Molnar <mingo@elte.hu>
To: Neil Brown <neilb@suse.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
Andrew Morton <akpm@osdl.org>,
linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: md deadlock (was Re: 2.6.18-mm2)
Date: Tue, 10 Oct 2006 08:42:28 +0200 [thread overview]
Message-ID: <20061010064228.GA6311@elte.hu> (raw)
In-Reply-To: <17707.6447.329255.930851@cse.unsw.edu.au>
* Neil Brown <neilb@suse.de> wrote:
> --- .prev/include/linux/mutex.h 2006-10-10 12:37:04.000000000 +1000
> +++ ./include/linux/mutex.h 2006-10-10 12:40:20.000000000 +1000
> @@ -125,8 +125,9 @@ extern int fastcall mutex_lock_interrupt
>
> #ifdef CONFIG_DEBUG_LOCK_ALLOC
> extern void mutex_lock_nested(struct mutex *lock, unsigned int subclass);
> +extern int mutex_lock_interruptible_nested(struct mutex *lock, unsigned int subclass);
> #else
> -# define mutex_lock_nested(lock, subclass) mutex_lock(lock)
> +# define mutex_lock_interruptible_nested(lock, subclass) mutex_interruptible_lock(lock)
> #endif
> EXPORT_SYMBOL_GPL(mutex_lock_nested);
> +int __sched
> +mutex_lock_interruptible_nested(struct mutex *lock, unsigned int subclass)
> +{
> + might_sleep();
> + return __mutex_lock_common(lock, TASK_INTERRUPTIBLE, subclass);
> +}
> +
> +EXPORT_SYMBOL_GPL(mutex_lock_interruptible_nested);
looks good to me. (small style nit: maybe insert a newline after the
first EXPORT_SYMBOL_GPL line)
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2006-10-10 6:50 UTC|newest]
Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 8:46 2.6.18-mm2 Andrew Morton
2006-09-28 11:54 ` 2.6.18-mm2 Michal Piotrowski
2006-09-29 12:12 ` md deadlock (was Re: 2.6.18-mm2) Peter Zijlstra
2006-09-29 12:52 ` Neil Brown
2006-09-29 14:03 ` Peter Zijlstra
2006-10-02 13:47 ` Peter Zijlstra
2006-10-10 3:53 ` Neil Brown
2006-10-10 6:42 ` Ingo Molnar [this message]
2006-09-28 17:50 ` 2.6.18-mm2 Steve Fox
2006-09-28 19:00 ` 2.6.18-mm2 thunder7
2006-09-28 21:01 ` 2.6.18-mm2 Andrew Morton
2006-09-28 22:45 ` 2.6.18-mm2 Stephen Hemminger
2006-10-04 13:42 ` 2.6.18-mm2 boot failure on x86-64 Steve Fox
2006-10-04 15:45 ` Andrew Morton
2006-10-04 15:55 ` Vivek Goyal
2006-10-04 15:56 ` Andi Kleen
2006-10-05 1:57 ` Keith Mannthey
2006-10-04 16:41 ` Steve Fox
2006-10-05 0:06 ` Andrew Morton
2006-10-05 0:51 ` Vivek Goyal
2006-10-05 0:57 ` Andi Kleen
2006-10-05 1:08 ` Martin Bligh
2006-10-05 2:05 ` Keith Mannthey
2006-10-05 14:53 ` Steve Fox
2006-10-05 15:12 ` Badari Pulavarty
2006-10-05 15:32 ` Steve Fox
2006-10-05 15:40 ` Andi Kleen
2006-10-05 17:57 ` Steve Fox
2006-10-05 18:27 ` Andi Kleen
2006-10-05 18:51 ` Steve Fox
2006-10-05 19:05 ` Andi Kleen
2006-10-05 20:42 ` Steve Fox
2006-10-05 20:50 ` Andi Kleen
2006-10-06 2:23 ` Steve Fox
2006-10-06 14:33 ` Mel Gorman
2006-10-06 15:36 ` Vivek Goyal
2006-10-06 17:11 ` Mel Gorman
2006-10-06 17:34 ` Vivek Goyal
2006-10-06 17:59 ` Vivek Goyal
2006-10-06 18:03 ` Steve Fox
2006-10-06 20:04 ` Vivek Goyal
2006-10-09 9:53 ` Mel Gorman
2006-10-16 18:16 ` Vivek Goyal
2006-10-16 23:58 ` Andrew Morton
2006-10-17 12:18 ` Adrian Bunk
2006-10-17 17:32 ` Mel Gorman
2006-10-05 18:52 ` Vivek Goyal
2006-10-05 19:08 ` Andi Kleen
2006-10-05 20:25 ` Steve Fox
2006-10-05 20:39 ` Mel Gorman
2006-10-05 20:51 ` Andi Kleen
2006-10-05 23:14 ` 2.6.18-mm2 boot failure on x86-64 II Andi Kleen
2006-10-05 23:32 ` keith mannthey
2006-10-05 23:35 ` Andi Kleen
2006-10-05 23:58 ` keith mannthey
2006-10-06 0:02 ` Badari Pulavarty
2006-10-06 0:12 ` Andrew Morton
2006-09-28 22:39 ` 2.6.18-mm2 Jim Cromie
2006-09-28 23:08 ` 2.6.18-mm2 Andi Kleen
2006-09-29 20:14 ` 2.6.18-mm2 Ingo Molnar
2006-09-29 20:36 ` 2.6.18-mm2 Andi Kleen
2006-09-29 20:32 ` 2.6.18-mm2 Ingo Molnar
2006-09-29 20:58 ` 2.6.18-mm2 Andi Kleen
2006-09-29 21:14 ` [patch] fix !apic build breakage Ingo Molnar
2006-09-29 21:44 ` Andi Kleen
2006-09-29 21:41 ` Ingo Molnar
2006-09-29 21:44 ` 2.6.18-mm2 Alan Cox
2006-09-29 21:36 ` 2.6.18-mm2 Dave Jones
2006-09-29 21:46 ` 2.6.18-mm2 Andi Kleen
2006-09-28 22:44 ` 2.6.18-mm2 Matthias Hentges
2006-09-29 3:19 ` 2.6.18-mm2 - oops in cache_alloc_refill() Valdis.Kletnieks
2006-09-29 3:29 ` Andrew Morton
2006-09-29 3:58 ` Valdis.Kletnieks
2006-09-29 15:19 ` Valdis.Kletnieks
2006-09-29 19:45 ` Andrew Morton
2006-09-30 0:01 ` Valdis.Kletnieks
2006-09-30 1:20 ` Andrew Morton
2006-09-30 1:33 ` Jean Tourrilhes
2006-09-30 3:31 ` Valdis.Kletnieks
2006-09-30 7:50 ` Valdis.Kletnieks
2006-09-30 8:33 ` Andrew Morton
2006-09-30 1:40 ` Jean Tourrilhes
2006-09-30 3:31 ` Valdis.Kletnieks
2006-09-30 1:57 ` Makefile for linux modules x z
2006-09-30 8:55 ` Sam Ravnborg
2006-09-30 1:59 ` x z
2006-10-02 17:52 ` 2.6.18-mm2 - oops in cache_alloc_refill() Jean Tourrilhes
2006-10-02 19:57 ` Valdis.Kletnieks
2006-10-03 15:58 ` Samuel Tardieu
2006-10-03 16:34 ` Jean Tourrilhes
2006-10-03 16:45 ` Samuel Tardieu
2006-10-03 17:07 ` Jean Tourrilhes
2006-10-05 22:37 ` Pavel Roskin
2006-10-05 22:42 ` Jean Tourrilhes
2006-09-29 19:47 ` Christoph Lameter
2006-09-29 13:57 ` 2.6.18-mm2 J.A. Magallón
2006-09-29 14:39 ` 2.6.18-mm2 Matthew Wilcox
2006-09-29 17:15 ` 2.6.18-mm2 Alan Cox
2006-09-29 23:50 ` 2.6.18-mm2 Frederik Deweerdt
2006-09-29 23:43 ` 2.6.18-mm2 Alan Cox
2006-09-30 14:09 ` [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2) Frederik Deweerdt
2006-09-30 14:19 ` Alan Cox
2006-09-30 13:51 ` Willy Tarreau
2006-09-30 23:58 ` Jeff Garzik
2006-10-01 14:28 ` Matthew Wilcox
2006-10-01 19:05 ` Arjan van de Ven
2006-10-01 19:19 ` Jeff Garzik
2006-10-01 19:34 ` Arjan van de Ven
2006-10-01 19:36 ` Matthew Wilcox
2006-10-01 19:42 ` Jeff Garzik
2006-10-02 2:12 ` Arjan van de Ven
2006-10-02 20:00 ` [RFC PATCH] pci_request_irq (was [-mm patch] aic7xxx: check irq validity) Frederik Deweerdt
2006-10-02 18:15 ` Matthew Wilcox
2006-10-02 21:09 ` Frederik Deweerdt
2006-10-02 20:07 ` [RFC PATCH] move aic7xxx to pci_request_irq Frederik Deweerdt
2006-10-02 18:27 ` Matthew Wilcox
2006-10-02 21:02 ` Frederik Deweerdt
2006-10-03 3:45 ` Arjan van de Ven
2006-10-02 20:11 ` [RFC PATCH] move tg3 " Frederik Deweerdt
2006-10-02 18:28 ` Matthew Wilcox
2006-10-02 21:04 ` Frederik Deweerdt
2006-10-03 7:18 ` Arjan van de Ven
2006-10-02 20:12 ` [RFC PATCH] move drm " Frederik Deweerdt
2006-10-02 18:37 ` Matthew Wilcox
2006-10-02 21:07 ` Frederik Deweerdt
2006-10-02 20:36 ` Alan Cox
2006-10-02 22:26 ` Frederik Deweerdt
2006-10-02 23:54 ` Dave Airlie
2006-10-03 7:17 ` Frederik Deweerdt
2006-10-03 3:58 ` [RFC PATCH] pci_request_irq (was [-mm patch] aic7xxx: check irq validity) Randy Dunlap
2006-10-01 21:31 ` [-mm patch] aic7xxx: check irq validity (was Re: 2.6.18-mm2) Frederik Deweerdt
2006-09-30 15:26 ` 2.6.18-mm2 James Bottomley
2006-09-30 16:21 ` 2.6.18-mm2 Matthew Wilcox
2006-09-30 17:20 ` 2.6.18-mm2 Mark Rustad
2006-09-30 20:54 ` 2.6.18-mm2 Alan Cox
2006-09-29 23:15 ` 2.6.18-mm2 J.A. Magallón
2006-09-30 7:04 ` 2.6.18-mm2 - possible recursive locking detected Borislav Petkov
2006-09-30 8:28 ` Andrew Morton
2006-09-30 18:19 ` Davide Libenzi
[not found] ` <20060930133706.GA3291@melchior.yamamaya.is-a-geek.org>
2006-09-30 19:53 ` 2.6.18-mm2 Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010064228.GA6311@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox