From: Jean Delvare <khali@linux-fr.org>
To: Hans de Goede <j.w.r.degoede@hhs.nl>
Cc: Jeff Garzik <jeff@garzik.org>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hwmon/abituguru: handle sysfs errors
Date: Tue, 10 Oct 2006 11:34:41 +0200 [thread overview]
Message-ID: <20061010113441.24b19b99.khali@linux-fr.org> (raw)
In-Reply-To: <452B6569.7050404@hhs.nl>
Hans,
> > * We want to delete all the device files at regular cleanup time (after
> > unregistering with the hwmon class).
>
> Is this really nescesarry? AFAIK the files get deleted when the device
> gets deleted.
The point is that the device shouldn't be deleted if we were following
the device driver model. After all the uGuru device exists in your
system before the abituguru driver is loaded, and is still there after
the driver is unloaded.
Now I agree that for now it won't make a difference, be we are
preparing for the future, and all other hardware monitoring drivers
were updated that way already.
> > * It's OK to call device_create_file() on a non-existent file, so the
> > error path can be simplified.
>
> ?? You mean device_remove_file I assume?
Oops, yes, that was a typo, sorry.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2006-10-10 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 6:53 [PATCH] hwmon/abituguru: handle sysfs errors Jeff Garzik
2006-10-10 7:27 ` Hans de Goede
2006-10-10 9:08 ` Jean Delvare
2006-10-10 9:18 ` Hans de Goede
2006-10-10 9:34 ` Jean Delvare [this message]
2006-10-12 4:31 ` Dmitry Torokhov
2006-10-12 15:42 ` Jean Delvare
2006-10-16 3:56 ` Dmitry Torokhov
2006-12-02 11:36 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010113441.24b19b99.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=akpm@osdl.org \
--cc=j.w.r.degoede@hhs.nl \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox