Re: [patch 2/2] round_jiffies users

Ingo Oeser
2006-10-10T16:48:06Z

Hi Arjan,

Arjan van de Ven wrote:
> Index: linux-2.6.19-rc1-git6/mm/slab.c
> ===================================================================
> --- linux-2.6.19-rc1-git6.orig/mm/slab.c
> +++ linux-2.6.19-rc1-git6/mm/slab.c
> @@ -926,7 +926,7 @@ static void __devinit start_cpu_timer(in
> if (keventd_up() && reap_work->func == NULL) {
> init_reap_node(cpu);
> INIT_WORK(reap_work, cache_reap, NULL);
> - schedule_delayed_work_on(cpu, reap_work, HZ + 3 * cpu);
> + schedule_delayed_work_on(cpu, reap_work, __round_jiffies_relative(HZ, cpu));
> }
> }
>

Did you changed the behavior by intention?
You seem to miss the factor "3" here. This hunk should read:

--- linux-2.6.19-rc1-git6.orig/mm/slab.c
+++ linux-2.6.19-rc1-git6/mm/slab.c
@@ -926,7 +926,7 @@ static void __devinit start_cpu_timer(in
if (keventd_up() && reap_work->func == NULL) {
init_reap_node(cpu);
INIT_WORK(reap_work, cache_reap, NULL);
- schedule_delayed_work_on(cpu, reap_work, HZ + 3 * cpu);
+ schedule_delayed_work_on(cpu, reap_work, __round_jiffies_relative(HZ, 3 * cpu));
}
}

In case you apply it:

Signed-off-by: Ingo Oese <netdev@axxeo.de>

Regards

Ingo Oeser