From: Stefan Seyfried <seife@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Pavel Machek <pavel@suse.cz>, Jiri Kosina <jikos@jikos.cz>,
linux-acpi@intel.com, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>, Len Brown <len.brown@intel.com>
Subject: Re: [PATCH] preserve correct battery state through suspend/resume cycles
Date: Tue, 10 Oct 2006 14:10:45 +0200 [thread overview]
Message-ID: <20061010121045.GQ19765@suse.de> (raw)
In-Reply-To: <200610100052.10008.rjw@sisk.pl>
On Tue, Oct 10, 2006 at 12:52:09AM +0200, Rafael J. Wysocki wrote:
> On Sunday, 8 October 2006 20:42, Pavel Machek wrote:
> > > echo "platform" > /sys/power/disk
> > > echo "disk" > /sys/power/state
> >
> > Maybe we should change the default in 2.6.20 or so?
>
> Well, I think swsusp should work with "shutdown" just as well. If it doesn't,
> that means there are some bugs in the ACPI code which should be fixed.
> By using "platform" as the default method we'll be hiding those bugs IMHO.
I'm not really intimately familiar with the ACPI spec, but IIRC those AML
methods executed by pm_ops->prepare and pm_ops->finish are mandatory for
suspending ACPI enabled machines. So using "platform" as a default seems
reasonable (assuming that on non-ACPI machines, pm_ops->{prepare,finish} will
be a noop anyway)
--
Stefan Seyfried
QA / R&D Team Mobile Devices | "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg | "Well, surrounding them's out."
next prev parent reply other threads:[~2006-10-10 12:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-28 2:50 [PATCH] preserve correct battery state through suspend/resume cycles Jiri Kosina
2006-09-30 11:48 ` Stefan Seyfried
2006-10-08 18:42 ` Pavel Machek
2006-10-09 22:52 ` Rafael J. Wysocki
2006-10-10 10:50 ` Pavel Machek
2006-10-10 12:10 ` Stefan Seyfried [this message]
2006-10-10 12:37 ` Rafael J. Wysocki
2006-10-10 16:39 ` Pavel Machek
2006-10-06 21:43 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061010121045.GQ19765@suse.de \
--to=seife@suse.de \
--cc=akpm@osdl.org \
--cc=jikos@jikos.cz \
--cc=len.brown@intel.com \
--cc=linux-acpi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox