Sparc64 stopped building - sigset_t unrecognized in compat.h

Sparc64 stopped building - sigset_t unrecognized in compat.h

[Paul Jackson]

Sometime on or about the change to include/linux/compat.h:

    changeset:   39069:fefadae8104d
    parent:      38900:a2856d056930
    user:        David S. Miller <davem@sunset.davemloft.net>
    date:        Tue Oct  3 04:24:18 2006 +0700
    summary:     [SPARC64]: Move signal compat bits to new header file.

which added the line:

    extern void sigset_from_compat(sigset_t *set, compat_sigset_t *compat);

my crosstool compile of sparc64 for 2.6.18-mm3 stopped building.

    $ make init/main.o

fails on the "sigset_t *set", with:

    In file included from include/asm/signal.h:11,
		     from include/linux/signal.h:4,
		     from include/linux/sched.h:67,
		     from include/linux/module.h:9,
		     from init/main.c:13:
    include/linux/compat.h:231: error: parse error before '*' token
    include/linux/compat.h:231: warning: function declaration isn't a prototype
    make[1]: *** [init/main.o] Error 1
    make: *** [init/main.o] Error 2

P.S. -- Looks like I'm not the first to notice.  Adding Dr. von Brand
        and Andrew to my cc list.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401

Re: Sparc64 stopped building - sigset_t unrecognized in compat.h

[David Miller]

From: Paul Jackson <pj@sgi.com>
Date: Tue, 10 Oct 2006 11:59:40 -0700

> Sometime on or about the change to include/linux/compat.h:
> 
>     changeset:   39069:fefadae8104d
>     parent:      38900:a2856d056930
>     user:        David S. Miller <davem@sunset.davemloft.net>
>     date:        Tue Oct  3 04:24:18 2006 +0700
>     summary:     [SPARC64]: Move signal compat bits to new header file.
> 
> which added the line:
> 
>     extern void sigset_from_compat(sigset_t *set, compat_sigset_t *compat);
> 
> my crosstool compile of sparc64 for 2.6.18-mm3 stopped building.

And then there is a changeset I made right after that one which
fixes the build by removing the asm/signal.h include from asm/compat.h.

Re: Sparc64 stopped building - sigset_t unrecognized in compat.h

[Andrew Morton]

On Tue, 10 Oct 2006 11:59:40 -0700
Paul Jackson <pj@sgi.com> wrote:

> Sometime on or about the change to include/linux/compat.h:
> 
>     changeset:   39069:fefadae8104d
>     parent:      38900:a2856d056930
>     user:        David S. Miller <davem@sunset.davemloft.net>
>     date:        Tue Oct  3 04:24:18 2006 +0700
>     summary:     [SPARC64]: Move signal compat bits to new header file.
> 
> which added the line:
> 
>     extern void sigset_from_compat(sigset_t *set, compat_sigset_t *compat);
> 
> my crosstool compile of sparc64 for 2.6.18-mm3 stopped building.

That build error came from the CONFIG_BLOCK patches and Dave's change was
intended to fix it rather than creating it.

2.6.19-rc1-mm1 builds OK on sparc64.

Re: Sparc64 stopped building - sigset_t unrecognized in compat.h

[Paul Jackson]

> 2.6.19-rc1-mm1 builds OK on sparc64.

Good - I won't worry about 2.6.18-mm3 anymore.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401