public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Timo Teras <timo.teras@solidboot.com>
To: Russell King <rmk+lkml@arm.linux.org.uk>, drzeus-list@drzeus.cx
Cc: Timo Teras <timo.teras@solidboot.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] MMC: Do not set unsupported bits in OCR response
Date: Tue, 10 Oct 2006 16:23:39 +0300	[thread overview]
Message-ID: <20061010132339.GA14769@mail.solidboot.com> (raw)
In-Reply-To: <20061009165317.GA6431@flint.arm.linux.org.uk>

The card might go to inactive state (according to specification), if
there are unsupported bits set in the OCR.

Signed-off-by: Timo Teras <timo.teras@solidboot.com>

---

 drivers/mmc/mmc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index ee8863c..c6f3077 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -475,7 +475,7 @@ static u32 mmc_select_voltage(struct mmc
        if (bit) {
                bit -= 1;
 
-               ocr = 3 << bit;
+               ocr &= 3 << bit;
 
                host->ios.vdd = bit;
                mmc_set_ios(host);


      parent reply	other threads:[~2006-10-10 13:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-09 15:00 [PATCH] MMC: Select only one voltage bit in OCR response Timo Teras
2006-10-09 16:53 ` Russell King
2006-10-09 17:23   ` Timo Teras
2006-10-16  6:34     ` Pierre Ossman
2006-10-22  9:25       ` Pierre Ossman
2006-10-31 10:05       ` Russell King
2006-10-31 15:24         ` Juha Yrjola
2006-11-02 18:37           ` Pierre Ossman
2006-10-10 13:23   ` Timo Teras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061010132339.GA14769@mail.solidboot.com \
    --to=timo.teras@solidboot.com \
    --cc=drzeus-list@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox