From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Adrian Bunk <bunk@stusta.de>
Cc: Rogier Wolff <R.E.Wolff@bitwizard.nl>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [2.6.19 patch] drivers/char/specialix.c: fix the baud conversion
Date: Tue, 10 Oct 2006 14:01:19 +0200 [thread overview]
Message-ID: <200610101401.20295.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20061010061747.GC3650@stusta.de>
[-- Attachment #1: Type: text/plain, Size: 1136 bytes --]
Adrian Bunk wrote:
> On Mon, Oct 09, 2006 at 08:37:45AM +0200, Rogier Wolff wrote:
> > On Mon, Oct 09, 2006 at 12:18:19AM +0200, Adrian Bunk wrote:
> > > + if (baud == 38400) {
> > > if ((port->flags & ASYNC_SPD_MASK) == ASYNC_SPD_HI)
> > > baud ++;
> > > if ((port->flags & ASYNC_SPD_MASK) == ASYNC_SPD_VHI)
> > > baud += 2;
> > > }
> > >
> > > Increasing the index for baud_table[] by 1 or 2 is quite different from
> > > increasing baud by 1 or 2.
> >
> > In that range,
> > baud <<= 1;
> > and
> > baud <<= 2;
> >
> > should work.
>
> Thanks for the hint.
>
> What about the patch below?
> @@ -1090,9 +1085,9 @@
>
> if (baud == 38400) {
> if ((port->flags & ASYNC_SPD_MASK) == ASYNC_SPD_HI)
> - baud ++;
> + baud <<= 1;
> if ((port->flags & ASYNC_SPD_MASK) == ASYNC_SPD_VHI)
> - baud += 2;
> + baud <<= 2;
> }
>
> if (!baud) {
Neither is 38400 <<= 1 == 57600 nor is 38400 <<= 2 == 115200. You should just
set baud to the value you want instead of doing tricks here.
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-10-10 12:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-08 22:18 drivers/char/specialix.c: broken baud conversion Adrian Bunk
2006-10-09 6:37 ` Rogier Wolff
2006-10-10 6:17 ` [2.6.19 patch] drivers/char/specialix.c: fix the " Adrian Bunk
2006-10-10 12:01 ` Rolf Eike Beer [this message]
2006-10-11 4:48 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610101401.20295.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=R.E.Wolff@bitwizard.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox