Re: [stable] [patch 06/67] Video: cx24123: fix PLL divisor setup

Greg KH
2006-10-11T23:06:50Z

On Wed, Oct 11, 2006 at 05:36:20PM -0400, Michael Krufky wrote:
> Greg KH wrote:
> > On Wed, Oct 11, 2006 at 05:15:35PM -0400, Michael Krufky wrote:
> >> Greg KH wrote:
> >>> -stable review patch. If anyone has any objections, please let us know.
> >>>
> >>> ------------------
> >>> From: Yeasah Pell <yeasah@schwide.net>
> >>>
> >>> The cx24109 datasheet says: "NOTE: if A=0, then N=N+1"
> >>>
> >>> The current code is the result of a misinterpretation of the datasheet to
> >>> mean exactly the opposite of the requirement -- The actual value of N is 1
> >>> greater than the value written when A is 0, so 1 needs to be *subtracted*
> >>> from it to compensate.
> >>>
> >>> Signed-off-by: Yeasah Pell <yeasah@schwide.net>
> >>> Signed-off-by: Steven Toth <stoth@hauppauge.com>
> >>> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
> >>> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >> Greg,
> >>
> >> When you apply this patch to your 2.6.18.y tree (and also to your
> >> 2.6.17.y tree) , can you please preceed the patch title with 'DVB'
> >> instead of 'VIDEO' ?
> >>
> >> I'll be sure to specify the subsystem, instead of only the driver name
> >> in future patches.
> >
> > Yes, it's better for you to specifiy it, instead of having me guess at
> > what it should be classified as :)
> >
> > I'll try to go edit the existing patches to fix this,
>
> OOPS! I just saw your -stable commit.
>
> Slight misunderstanding, Greg...
>
> Out of those six patches that I sent to you, only "cx24123: fix PLL
> divisor setup" is a DVB patch... The remaining 5 patches are V4L patches.
>
> Sorry for the confusion.

Ok, can you check this latest change to make sure I got it right this
time? And the .17 patches were all DVB: right?

thanks,

greg k-h