Re: [patch 48/67] Fix VIDIOC_ENUMSTD bug

Mauro Carvalho Chehab
2006-10-11T22:11:49Z

Em Qua, 2006-10-11 às 17:49 -0400, Michael Krufky escreveu:
> Jonathan Corbet wrote:
> >> So any application which passes in index=0 gets EINVAL right off the bat
> >> - and, in fact, this is what happens to mplayer. So I think the
> >> following patch is called for, and maybe even appropriate for a 2.6.18.x
> >> stable release.
> >
> > The fix is worth having, though I guess I'm no longer 100% sure it's
> > necessary for -stable, since I don't think anything in-tree other than
> > vivi uses this interface in 2.6.18.
True. No real reason to fix into stable. On the other hand, it won't
hurt -stable to have this fix.

> > If you are going to include it,
> > though, it makes sense to put in Sascha's fix too - both are needed to
> > make the new v4l2 ioctl() interface operate as advertised.

> This is fine with me... I have added cc to Mauro, he might want to add
> his sign-off as well.
By applying patch 48 into -stable, for sure Sascha fix is required.

>
> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

Cheers,
Mauro.