From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
"Theodore Ts'o" <tytso@mit.edu>,
Randy Dunlap <rdunlap@xenotime.net>,
Dave Jones <davej@redhat.com>,
Chuck Wolber <chuckw@quantumlinux.com>,
Chris Wedgwood <reviews@ml.cw.f00f.org>,
Michael Krufky <mkrufky@linuxtv.org>,
torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk,
Jeff Dike <jdike@addtoit.com>,
Paolo Giarrusso <blaisorblade@yahoo.it>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [patch 04/67] UML: Fix UML build failure
Date: Wed, 11 Oct 2006 14:03:44 -0700 [thread overview]
Message-ID: <20061011210344.GE16627@kroah.com> (raw)
In-Reply-To: <20061011210310.GA16627@kroah.com>
[-- Attachment #1: uml-fix-uml-build-failure.patch --]
[-- Type: text/plain, Size: 2645 bytes --]
-stable review patch. If anyone has any objections, please let us know.
------------------
From: Jeff Dike <jdike@addtoit.com>
don't know if the following is already queued, it fixes an ARCH=um build
failure, evidence here:
http://marc.theaimsgroup.com/?l=linux-kernel&m=115875912525137&w=2
and following thread.
Cc-ing uml maintainers and I hope I didn't follow too many
Submitting-patches rules...
The patch is taken from:
http://user-mode-linux.sourceforge.net/work/current/2.6/2.6.18/patches/no-syscallx
Since the syscallx macros seem to be under threat, this patch stops
using them, using syscall instead.
Acked-by: Jeff Dike <jdike@addtoit.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
arch/um/os-Linux/process.c | 4 +---
arch/um/os-Linux/sys-i386/tls.c | 4 +---
arch/um/os-Linux/tls.c | 7 ++-----
3 files changed, 4 insertions(+), 11 deletions(-)
--- linux-2.6.18.orig/arch/um/os-Linux/process.c
+++ linux-2.6.18/arch/um/os-Linux/process.c
@@ -141,11 +141,9 @@ void os_usr1_process(int pid)
* syscalls, and also breaks with clone(), which does not unshare the TLS.
*/
-inline _syscall0(pid_t, getpid)
-
int os_getpid(void)
{
- return(getpid());
+ return syscall(__NR_getpid);
}
int os_getpgrp(void)
--- linux-2.6.18.orig/arch/um/os-Linux/sys-i386/tls.c
+++ linux-2.6.18/arch/um/os-Linux/sys-i386/tls.c
@@ -3,8 +3,6 @@
#include "sysdep/tls.h"
#include "user_util.h"
-static _syscall1(int, get_thread_area, user_desc_t *, u_info);
-
/* Checks whether host supports TLS, and sets *tls_min according to the value
* valid on the host.
* i386 host have it == 6; x86_64 host have it == 12, for i386 emulation. */
@@ -17,7 +15,7 @@ void check_host_supports_tls(int *suppor
user_desc_t info;
info.entry_number = val[i];
- if (get_thread_area(&info) == 0) {
+ if(syscall(__NR_get_thread_area, &info) == 0){
*tls_min = val[i];
*supports_tls = 1;
return;
--- linux-2.6.18.orig/arch/um/os-Linux/tls.c
+++ linux-2.6.18/arch/um/os-Linux/tls.c
@@ -48,14 +48,11 @@ int os_get_thread_area(user_desc_t *info
#ifdef UML_CONFIG_MODE_TT
#include "linux/unistd.h"
-static _syscall1(int, get_thread_area, user_desc_t *, u_info);
-static _syscall1(int, set_thread_area, user_desc_t *, u_info);
-
int do_set_thread_area_tt(user_desc_t *info)
{
int ret;
- ret = set_thread_area(info);
+ ret = syscall(__NR_set_thread_area, info);
if (ret < 0) {
ret = -errno;
}
@@ -66,7 +63,7 @@ int do_get_thread_area_tt(user_desc_t *i
{
int ret;
- ret = get_thread_area(info);
+ ret = syscall(__NR_get_thread_area, info);
if (ret < 0) {
ret = -errno;
}
--
next prev parent reply other threads:[~2006-10-11 21:33 UTC|newest]
Thread overview: 90+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061011204756.642936754@quad.kroah.org>
2006-10-11 21:03 ` [patch 00/67] 2.6.18-stable review Greg KH
2006-10-11 21:03 ` [patch 01/67] NET_SCHED: Fix fallout from dev->qdisc RCU change Greg KH
2006-10-11 21:03 ` [patch 02/67] uml: allow using again x86/x86_64 crypto code Greg KH
2006-10-11 21:03 ` [patch 03/67] uml: use DEFCONFIG_LIST to avoid reading hosts config Greg KH
2006-10-11 21:03 ` Greg KH [this message]
2006-10-11 21:03 ` [patch 05/67] Video: Fix msp343xG handling regression Greg KH
2006-10-11 21:03 ` [patch 06/67] Video: cx24123: fix PLL divisor setup Greg KH
2006-10-11 21:15 ` Michael Krufky
2006-10-11 21:29 ` Greg KH
2006-10-11 21:36 ` Michael Krufky
2006-10-11 23:01 ` [stable] " Greg KH
2006-10-11 23:58 ` Michael Krufky
2006-10-13 18:48 ` Greg KH
2006-10-11 21:03 ` [patch 07/67] Video: pvrusb2: Solve mutex deadlock Greg KH
2006-10-11 21:04 ` [patch 09/67] Video: pvrusb2: Suppress compiler warning Greg KH
2006-10-11 21:04 ` [patch 10/67] Video: pvrusb2: Limit hor res for 24xxx devices Greg KH
2006-10-11 21:04 ` [patch 11/67] zd1211rw: ZD1211B ASIC/FWT, not jointly decoder Greg KH
2006-10-12 13:41 ` John W. Linville
2006-10-11 21:04 ` [patch 12/67] S390: user readable uninitialised kernel memory (CVE-2006-5174) Greg KH
2006-10-11 21:04 ` [patch 13/67] IB/mthca: Fix lid used for sending traps Greg KH
2006-10-11 21:04 ` [patch 14/67] USB: Allow compile in g_ether, fix typo Greg KH
2006-10-11 21:04 ` [patch 15/67] ALSA: Fix initiailization of user-space controls Greg KH
2006-10-11 21:04 ` [patch 16/67] jbd: fix commit of ordered data buffers Greg KH
2006-10-12 11:55 ` Jan Kara
2006-10-12 17:16 ` Greg KH
2006-10-11 21:04 ` [patch 17/67] Fix longstanding load balancing bug in the scheduler Greg KH
2006-10-12 7:30 ` Arjan van de Ven
2006-10-11 21:04 ` [patch 18/67] zone_reclaim: dynamic slab reclaim Greg KH
2006-10-12 7:31 ` Arjan van de Ven
2006-10-12 10:04 ` Christoph Lameter
2006-10-11 21:04 ` [patch 19/67] mv643xx_eth: fix obvious typo, which caused build breakage Greg KH
2006-10-11 21:05 ` [patch 20/67] netdrvr: lp486e: fix typo Greg KH
2006-10-11 21:05 ` [patch 21/67] sky2: tx pause bug fix Greg KH
2006-10-11 21:05 ` [patch 22/67] sky2 network driver device ids Greg KH
2006-10-11 21:05 ` [patch 23/67] One line per header in Kbuild files to reduce conflicts Greg KH
2006-10-11 21:05 ` [patch 24/67] Fix ARM make headers_check Greg KH
2006-10-11 21:05 ` [patch 25/67] Fix make headers_check on sh Greg KH
2006-10-11 21:05 ` [patch 26/67] Fix make headers_check on sh64 Greg KH
2006-10-11 21:05 ` [patch 27/67] Fix make headers_check on m32r Greg KH
2006-10-11 21:05 ` [patch 28/67] Fix exported headers for SPARC, SPARC64 Greg KH
2006-10-11 21:05 ` [patch 29/67] Fix m68knommu exported headers Greg KH
2006-10-11 21:05 ` [patch 30/67] Fix H8300 " Greg KH
2006-10-11 21:06 ` [patch 31/67] Remove ARM26 header export Greg KH
2006-10-11 21:06 ` [patch 32/67] Remove UML " Greg KH
2006-10-11 21:06 ` [patch 33/67] Dont advertise (or allow) headers_{install,check} where inappropriate Greg KH
2006-10-11 21:06 ` [patch 34/67] Fix v850 exported headers Greg KH
2006-10-11 21:06 ` [patch 35/67] Clean up exported headers on CRIS Greg KH
2006-10-11 21:06 ` [patch 36/67] Remove offsetof() from user-visible <linux/stddef.h> Greg KH
2006-10-11 21:06 ` [patch 37/67] powerpc: fix building gdb against asm/ptrace.h Greg KH
2006-10-11 21:06 ` [patch 38/67] sysfs: remove duplicated dput in sysfs_update_file Greg KH
2006-10-11 21:06 ` [patch 39/67] powerpc: Fix ohare IDE irq workaround on old powermacs Greg KH
2006-10-11 21:07 ` [patch 40/67] i386 bootioremap / kexec fix Greg KH
2006-10-11 21:07 ` [patch 41/67] rtc: lockdep fix/workaround Greg KH
2006-10-11 21:07 ` [patch 42/67] do not free non slab allocated per_cpu_pageset Greg KH
2006-10-11 21:07 ` [patch 43/67] backlight: fix oops in __mutex_lock_slowpath during head /sys/class/graphics/fb0/bits_per_pixel /sys/class/graphics/fb0/blank /sys/class/graphics/fb0/console /sys/class/graphics/fb0/cursor /sys/class/graphics/fb0/dev /sys/class/graphics/fb0/device /sys/class/graphics/fb0/mode /sys/class/graphics/fb0/modes /sys/class/graphics/fb0/name /sys/class/graphics/fb0/pan /sys/class/graphics/fb0/rotate /sys/class/graphics/fb0/state /sys/class/graphics/fb0/stride /sys/class/graphics/fb0/subsystem /sys/class/graphics/fb0/uevent /sys/class/graphics/fb0/virtual_size Greg KH
2006-10-11 21:07 ` [patch 44/67] cpu to node relationship fixup: acpi_map_cpu2node Greg KH
2006-10-11 21:07 ` [patch 45/67] cpu to node relationship fixup: map cpu to node Greg KH
2006-10-11 21:07 ` [patch 46/67] i386: fix flat mode numa on a real numa system Greg KH
2006-10-11 21:07 ` [patch 47/67] load_module: no BUG if module_subsys uninitialized Greg KH
2006-10-11 21:07 ` [patch 48/67] Fix VIDIOC_ENUMSTD bug Greg KH
2006-10-11 21:46 ` Jonathan Corbet
2006-10-11 21:49 ` Michael Krufky
2006-10-11 22:10 ` Mauro Carvalho Chehab
2006-10-11 23:04 ` [stable] " Greg KH
2006-10-11 21:07 ` [patch 49/67] SPARC64: Fix serious bug in sched_clock() on sparc64 Greg KH
2006-10-11 21:07 ` [patch 50/67] CPUFREQ: Fix some more CPU hotplug locking Greg KH
2006-10-11 21:08 ` [patch 51/67] IPV6: bh_lock_sock_nested on tcp_v6_rcv Greg KH
2006-10-11 21:08 ` [patch 52/67] SPARC64: Fix sparc64 ramdisk handling Greg KH
2006-10-11 21:08 ` [patch 53/67] sata_mv: fix oops Greg KH
2006-10-11 21:08 ` [patch 54/67] PKT_SCHED: cls_basic: Use unsigned int when generating handle Greg KH
2006-10-11 21:08 ` [patch 55/67] IPV6: Disable SG for GSO unless we have checksum Greg KH
2006-10-11 21:08 ` [patch 56/67] MD: Fix problem where hot-added drives are not resynced Greg KH
2006-10-11 21:08 ` [patch 57/67] TCP: Fix and simplify microsecond rtt sampling Greg KH
2006-10-11 21:08 ` [patch 58/67] mm: bug in set_page_dirty_buffers Greg KH
2006-10-11 21:08 ` [patch 59/67] fbdev: correct buffer size limit in fbmem_read_proc() Greg KH
2006-10-11 21:08 ` [patch 60/67] rtc driver rtc-pcf8563 century bit inversed Greg KH
2006-10-11 21:08 ` [patch 61/67] invalidate_inode_pages2(): ignore page refcounts Greg KH
2006-10-11 21:09 ` [patch 62/67] scx200_hrt: fix precedence bug manifesting as 27x clock in 1 MHz mode Greg KH
2006-10-11 21:09 ` [patch 63/67] ide-generic: jmicron fix Greg KH
2006-10-11 21:09 ` [patch 64/67] x86-64: Calgary IOMMU: Fix off by one when calculating register space location Greg KH
2006-10-11 21:09 ` [patch 66/67] NETFILTER: NAT: fix NOTRACK checksum handling Greg KH
2006-10-11 21:09 ` [patch 67/67] block layer: elv_iosched_show should get elv_list_lock Greg KH
2006-10-11 21:36 ` [patch 00/67] 2.6.18-stable review Dave Jones
2006-10-11 21:59 ` Greg KH
2006-10-11 22:17 ` Dave Jones
2006-10-11 22:19 ` Dave Jones
2006-10-11 22:59 ` [stable] " Greg KH
2006-10-12 0:42 ` Theodore Tso
2006-10-12 16:35 ` [stable] " Greg KH
2006-10-12 16:51 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061011210344.GE16627@kroah.com \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=blaisorblade@yahoo.it \
--cc=chuckw@quantumlinux.com \
--cc=davej@redhat.com \
--cc=jdike@addtoit.com \
--cc=jmforbes@linuxtx.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=rdunlap@xenotime.net \
--cc=reviews@ml.cw.f00f.org \
--cc=stable@kernel.org \
--cc=torvalds@osdl.org \
--cc=tytso@mit.edu \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox