From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-kernel <linux-kernel@vger.kernel.org>,
sfr@canb.auug.org.au
Subject: Re: [PATCH] lockdep: annotate i386 apm
Date: Thu, 12 Oct 2006 10:02:12 +0200 [thread overview]
Message-ID: <20061012080212.GA14307@elte.hu> (raw)
In-Reply-To: <20061011233925.c9ba117a.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> > So, say interrupts were enabled when entering apm_bios_call*(); you now
> > save that in flags, disable interrupts, and enable them again.
> > Upon reaching local_irq_restore(), we'll hit the else branch with irq's
> > enabled and call trace_hardirqs_on(), which goes EEEK!
>
> I'd assumed lockdep was less stupid than that ;) This? Seems a bit
> overdone..
the problem is not lockdep but that the BIOS enables IRQs behind the
back of the kernel. Lockdep needs to be taught about that - if this
happens unconditionally then i'd suggest to insert an unconditional
trace_hardirqs_on() call to after the local_irq_save() that we do prior
calling the BIOS. (that will be a NOP if lockdep is not enabled)
Ingo
next prev parent reply other threads:[~2006-10-12 8:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-11 13:40 [PATCH] lockdep: annotate i386 apm Peter Zijlstra
2006-10-11 21:18 ` Andrew Morton
2006-10-12 6:06 ` Peter Zijlstra
2006-10-12 6:39 ` Andrew Morton
2006-10-12 6:50 ` Peter Zijlstra
2006-10-12 7:29 ` Andrew Morton
2006-10-12 8:13 ` Peter Zijlstra
2006-10-12 8:02 ` Ingo Molnar [this message]
2006-10-12 8:26 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061012080212.GA14307@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox