From: Misha Tomushev <misha@fabric7.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: KERNEL Linux <linux-kernel@vger.kernel.org>,
NETDEV Linux <netdev@vger.kernel.org>,
"Sriram Chidambaram" <schidambaram@fabric7.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 6/10] VIOC: New Network Device Driver
Date: Fri, 13 Oct 2006 10:51:07 -0700 [thread overview]
Message-ID: <200610131051.07557.misha@fabric7.com> (raw)
In-Reply-To: <20061009120324.56bac955@freekitty>
On Monday 09 October 2006 12:03 pm, Stephen Hemminger wrote:
> On Mon, 9 Oct 2006 11:09:39 -0700
>
> Misha Tomushev <misha@fabric7.com> wrote:
> > On Sunday 08 October 2006 12:27 am, Pavel Machek wrote:
> > > Hi!
> > >
> > > > + ecmd->phy_address = 0; /* !!! Stole from e1000 */
> > > > + ecmd->speed = 3; /* !!! Stole from e1000 */
> > >
> > > Eh?
> >
> > You are right. Will fix.
> >
> > > > +static void vnic_get_regs(struct net_device *netdev,
> > > > + struct ethtool_regs *regs, void *p)
> > > > +{
> > > > + struct vnic_device *vnicdev = netdev->priv;
> > > > + struct vioc_device *viocdev = vnicdev->viocdev;
> > >
> > > This looks ugly. What interface is that?
> Please just dump binary like other drivers. The code for ethtool allows
> per device decode. Move the decode to there.
>
> Yes, ethtool source does need a more generic register description language.
Signed-off-by: Misha Tomushev <misha@fabric7.com>
Please pull the patch from ftp://ftp.fabric7.com/VIOC/vioc_patch.2006-10-12-17-40
--
Misha Tomushev
misha@fabric7.com
prev parent reply other threads:[~2006-10-13 17:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-05 18:05 [PATCH 6/10] VIOC: New Network Device Driver Misha Tomushev
2006-10-08 7:27 ` Pavel Machek
2006-10-09 18:09 ` Misha Tomushev
2006-10-09 19:03 ` Stephen Hemminger
2006-10-13 17:51 ` Misha Tomushev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610131051.07557.misha@fabric7.com \
--to=misha@fabric7.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=schidambaram@fabric7.com \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox