From: Andrew Morton <akpm@osdl.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-serial@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] serial: handle pci_enable_device() failure upon resume
Date: Fri, 13 Oct 2006 13:15:16 -0700 [thread overview]
Message-ID: <20061013131516.227e99ee.akpm@osdl.org> (raw)
In-Reply-To: <20061013075953.GC28654@flint.arm.linux.org.uk>
On Fri, 13 Oct 2006 08:59:53 +0100
Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> On Wed, Oct 11, 2006 at 09:47:20PM -0400, Jeff Garzik wrote:
> > Signed-off-by: Jeff Garzik <jeff@garzik.org>
>
> NAK. What happens to the ports if pci_enable_device() fails and someone
> has them open?
They're screwed either way.
> It's far better to leave the must_check warning behind until it can be
> _correctly_ solved, rather than papering over the problem with bogus
> patches to return errors without taking an appropriate additional action.
>
> IOW, the warnings serve as a reminder that *proper* error handling needs
> to be implemented.
What would that error handling do?
Until that has been implemented, it would be good if we could at least spit
a printk telling people what failed, so when the machine later goes kaput
we know why it happened.
An appropriate place in which to perform that reporting is up in the
high-level resume code, so Jeff's patch is appropriate.
Right now, we get silent failure *and* a compile-time warning. It's hard
to see how that situation could be made worse.
next prev parent reply other threads:[~2006-10-13 20:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-12 1:47 [PATCH] serial: handle pci_enable_device() failure upon resume Jeff Garzik
2006-10-13 7:59 ` Russell King
2006-10-13 20:15 ` Andrew Morton [this message]
2006-10-13 23:15 ` Alan Cox
2006-10-14 8:38 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061013131516.227e99ee.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox