From: Greg KH <gregkh@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: Andrew Morton <akpm@osdl.org>, Shaohua Li <shaohua.li@intel.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: drivers/base/sys.c bug found
Date: Fri, 13 Oct 2006 22:11:44 -0700 [thread overview]
Message-ID: <20061014051144.GA17315@suse.de> (raw)
In-Reply-To: <45239D1F.7060102@garzik.org>
On Wed, Oct 04, 2006 at 07:38:07AM -0400, Jeff Garzik wrote:
> sysdev_driver::add is defined to return an error (as it should), but
> that error code is never checked.
Ick, good catch.
I hate those sysdev devices...
Hm, in sysdev_driver_register() we don't want to return any error there,
as it doesn't make sense to.
Shaohua, sysdev devices should not stop the notificiation if a single
add() function returns an error, right? All of the individual drivers
want to be notified of the device.
Bleah...did I mention I don't like these things...
thanks,
greg k-h
prev parent reply other threads:[~2006-10-14 5:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-04 11:38 drivers/base/sys.c bug found Jeff Garzik
2006-10-14 5:11 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061014051144.GA17315@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox