From: Joel Becker <Joel.Becker@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Greg KH <greg@kroah.com>,
Chandra Seetharaman <sekharan@us.ibm.com>,
ckrm-tech@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/5] Allow more than PAGESIZE data read in configfs
Date: Sat, 14 Oct 2006 13:10:16 -0700 [thread overview]
Message-ID: <20061014201016.GG2747@ca-server1.us.oracle.com> (raw)
In-Reply-To: <20061014124351.63434962.akpm@osdl.org>
On Sat, Oct 14, 2006 at 12:43:51PM -0700, Andrew Morton wrote:
> On Sat, 14 Oct 2006 01:01:07 -0700
> Greg KH <greg@kroah.com> wrote:
> > Argh!!!!
> >
> > Are you going to honestly tell me you have a single attribute in sysfs
> > that is larger than PAGE_SIZE?
>
> He does not. It's a matter of reusing existing facilities rather than
> impementing similar things in multiple places. The equivalent patch in
> configfs removed a decent amount of code:
Issues of PAGE_SIZE and attribute size aside, the patch posted
was incorrect. While they used seq_file, they implemented it in a
completely inefficent fashion, filling the entire buffer in one ->show()
call rather than letting multiple read(2) calls iterate their list.
Joel
--
"Anything that is too stupid to be spoken is sung."
- Voltaire
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2006-10-14 20:11 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 18:20 [PATCH 0/5] Allow more than PAGESIZE data read in configfs Chandra Seetharaman
2006-10-10 18:20 ` [PATCH 1/5] Fix a module count leak Chandra Seetharaman
2006-10-10 22:17 ` Joel Becker
2006-10-10 18:20 ` [PATCH 2/5] Use seq_file for read side of operations Chandra Seetharaman
2006-10-11 9:12 ` Joel Becker
2006-10-10 18:21 ` [PATCH 3/5] Change configfs_example.c to use the new interface Chandra Seetharaman
2006-10-10 18:21 ` [PATCH 4/5] Change Documentation to reflect " Chandra Seetharaman
2006-10-10 18:21 ` [PATCH 5/5] Change the existing code to use " Chandra Seetharaman
2006-10-10 20:35 ` [PATCH 0/5] Allow more than PAGESIZE data read in configfs Joel Becker
2006-10-10 21:31 ` [ckrm-tech] " Paul Menage
2006-10-10 21:58 ` Joel Becker
2006-10-10 23:13 ` Chandra Seetharaman
2006-10-11 0:15 ` Joel Becker
2006-10-11 0:49 ` Matt Helsley
2006-10-11 1:28 ` Joel Becker
2006-10-11 22:39 ` Greg KH
2006-10-11 23:26 ` Chandra Seetharaman
2006-10-12 4:17 ` Paul Jackson
2006-10-12 23:51 ` Greg KH
2006-10-13 0:16 ` Paul Jackson
2006-10-13 23:38 ` Matt Helsley
2006-10-13 23:40 ` Matt Helsley
2006-10-13 23:47 ` Paul Menage
2006-10-14 6:17 ` Greg KH
2006-10-14 23:14 ` Matt Helsley
2006-10-16 19:10 ` Chandra Seetharaman
2006-10-16 20:32 ` Paul Jackson
2006-10-16 22:29 ` Chandra Seetharaman
2006-10-17 2:59 ` Paul Jackson
2006-10-12 2:17 ` Matt Helsley
2006-10-12 23:54 ` Greg KH
2006-10-13 3:22 ` Matt Helsley
[not found] ` <20061011220619.GB7911@ca-server1.us.oracle.com>
[not found] ` <1160619516.18766.209.camel@localhost.localdomain>
2006-10-12 7:08 ` Joel Becker
2006-10-12 21:44 ` Paul Jackson
2006-10-12 22:51 ` Joel Becker
2006-10-13 0:01 ` Paul Jackson
2006-10-14 4:40 ` Greg KH
2006-10-13 23:37 ` Matt Helsley
2006-10-14 0:09 ` Joel Becker
2006-10-15 1:06 ` Matt Helsley
2006-10-15 19:07 ` Paul Jackson
2006-10-16 19:33 ` Chandra Seetharaman
2006-10-16 23:07 ` Joel Becker
2006-10-11 20:19 ` Andrew Morton
2006-10-11 21:41 ` Joel Becker
2006-10-11 22:18 ` Joel Becker
2006-10-11 22:48 ` Andrew Morton
2006-10-11 23:27 ` Chandra Seetharaman
2006-10-14 8:01 ` Greg KH
2006-10-14 19:43 ` Andrew Morton
2006-10-14 20:10 ` Joel Becker [this message]
2006-10-16 19:24 ` Chandra Seetharaman
2006-10-16 23:09 ` Joel Becker
2006-10-18 0:55 ` Chandra Seetharaman
2006-10-19 18:42 ` Joel Becker
2006-10-16 19:16 ` Chandra Seetharaman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061014201016.GG2747@ca-server1.us.oracle.com \
--to=joel.becker@oracle.com \
--cc=akpm@osdl.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sekharan@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox