public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
	davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] bnep endianness bug: filtering by packet type
Date: Mon, 16 Oct 2006 00:51:48 +0100	[thread overview]
Message-ID: <20061015235148.GZ29920@ftp.linux.org.uk> (raw)
In-Reply-To: <1160955253.14340.15.camel@localhost>

On Mon, Oct 16, 2006 at 01:34:13AM +0200, Marcel Holtmann wrote:
> Hi Al,
> 
> > <= and => don't work well on net-endian...
> 
> can we have a clean one for the BNEP part. Not one that changes
> something and then another one reverting it.

*shrug*

I can reorder, of course.  FWIW, I prefer to do a patch that annotates
existing use and provably does not change behaviour + fixes for whatever
crap shows up once said existing use is annotated, but if you prefer it
in opposite order...

OTOH, in this case bug is obvious enough as it is, so...  Will reorder
and send.

  reply	other threads:[~2006-10-15 23:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-15 21:31 [PATCH 4/4] bnep endianness bug: filtering by packet type Al Viro
2006-10-15 23:34 ` Marcel Holtmann
2006-10-15 23:51   ` Al Viro [this message]
2006-10-16  0:20     ` Al Viro
2006-10-16  0:20     ` Al Viro
2006-10-16  0:21     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061015235148.GZ29920@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox