Re: [patch 8/8] stacktrace filtering for fault-injection capabilities

Don Mullis
2006-09-19T17:41:10Z

On Tue, 2006-09-19 at 17:09 +0800, Akinobu Mita wrote:
> On Mon, Sep 18, 2006 at 10:57:51PM -0700, Don Mullis wrote:
> > Push fault-injection entries earlier in the list, so that they appear
> > nested under DEBUG_KERNEL in menuconfig/xconfig.
>
> Disabling the option Kernel debugging can hide all config options
> realated to fault-injection without this patch.
>
> Do I misunderstand something?
>

There's no problem with hiding per se, but rather with the indentation
level. It's most natural for the user to have dependent options
indented under their "parent". For an example, in "menuconfig" try
setting "Compile the kernel with frame unwind information";
notice that "Stack unwind support" appears immediately underneath
it, indented. The indentation reminds the user why "Stack unwind
support" has appeared.

Note that several of the pre-existing, non-fault-injection options
under "Kernel debugging", are also broken in this way.