* [PATCH] remove duplicated cpu_mask_to_apicid in x86_64 smp.h
@ 2006-10-14 7:19 Yinghai Lu
2006-10-16 10:21 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Yinghai Lu @ 2006-10-14 7:19 UTC (permalink / raw)
To: ak; +Cc: linux kernel mailing list, yhlu.kernel
[-- Attachment #1: Type: text/plain, Size: 633 bytes --]
inline function cpu_mask_to_apicid in smp.h is duplicated with macro
in mach_apic.h.
Signed-off-by: Yinghai Lu <yinghai.lu@amd.com>
diff --git a/include/asm-x86_64/smp.h b/include/asm-x86_64/smp.h
index d6b7c05..7ae7e7d 100644
--- a/include/asm-x86_64/smp.h
+++ b/include/asm-x86_64/smp.h
@@ -82,11 +82,6 @@ extern u8 x86_cpu_to_apicid[NR_CPUS]; /*
extern u8 x86_cpu_to_log_apicid[NR_CPUS];
extern u8 bios_cpu_apicid[];
-static inline unsigned int cpu_mask_to_apicid(cpumask_t cpumask)
-{
- return cpus_addr(cpumask)[0];
-}
-
static inline int cpu_present_to_apicid(int mps_cpu)
{
if (mps_cpu < NR_CPUS)
[-- Attachment #2: x86_64_smp_h.diff --]
[-- Type: text/x-patch, Size: 480 bytes --]
diff --git a/include/asm-x86_64/smp.h b/include/asm-x86_64/smp.h
index d6b7c05..7ae7e7d 100644
--- a/include/asm-x86_64/smp.h
+++ b/include/asm-x86_64/smp.h
@@ -82,11 +82,6 @@ extern u8 x86_cpu_to_apicid[NR_CPUS]; /*
extern u8 x86_cpu_to_log_apicid[NR_CPUS];
extern u8 bios_cpu_apicid[];
-static inline unsigned int cpu_mask_to_apicid(cpumask_t cpumask)
-{
- return cpus_addr(cpumask)[0];
-}
-
static inline int cpu_present_to_apicid(int mps_cpu)
{
if (mps_cpu < NR_CPUS)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] remove duplicated cpu_mask_to_apicid in x86_64 smp.h
2006-10-14 7:19 [PATCH] remove duplicated cpu_mask_to_apicid in x86_64 smp.h Yinghai Lu
@ 2006-10-16 10:21 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-10-16 10:21 UTC (permalink / raw)
To: Yinghai Lu; +Cc: linux kernel mailing list, yhlu.kernel
On Saturday 14 October 2006 09:19, Yinghai Lu wrote:
> inline function cpu_mask_to_apicid in smp.h is duplicated with macro
> in mach_apic.h.
Added thanks
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-10-16 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-14 7:19 [PATCH] remove duplicated cpu_mask_to_apicid in x86_64 smp.h Yinghai Lu
2006-10-16 10:21 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox