From: Matthew Wilcox <matthew@wil.cx>
To: linux-pci@atrey.karlin.mff.cuni.cz, linux-pm@lists.osdl.org,
linux-kernel@vger.kernel.org
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Greg KH <greg@kroah.com>,
Adam Belay <abelay@MIT.EDU>
Subject: Re: [PATCH] Block on access to temporarily unavailable pci device
Date: Tue, 17 Oct 2006 08:54:04 -0600 [thread overview]
Message-ID: <20061017145403.GK22289@parisc-linux.org> (raw)
In-Reply-To: <20061017145146.GJ22289@parisc-linux.org>
On Tue, Oct 17, 2006 at 08:51:46AM -0600, Matthew Wilcox wrote:
> I'll post the patch I used to test blocking device accesses separately.
Here it is. Not for applying.
Nacked-by: Matthew Wilcox <matthew@wil.cx>
diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
index a1d2e97..267bf76 100644
--- a/drivers/pci/pci-sysfs.c
+++ b/drivers/pci/pci-sysfs.c
@@ -175,6 +175,20 @@ msi_bus_store(struct device *dev, struct
return count;
}
+static ssize_t
+block_store(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct pci_dev *pdev = to_pci_dev(dev);
+
+ if (*buf == '0')
+ pci_unblock_user_cfg_access(pdev);
+ else if (*buf == '1')
+ pci_block_user_cfg_access(pdev);
+
+ return count;
+}
+
struct device_attribute pci_dev_attrs[] = {
__ATTR_RO(resource),
__ATTR_RO(vendor),
@@ -189,6 +203,7 @@ struct device_attribute pci_dev_attrs[]
__ATTR(broken_parity_status,(S_IRUGO|S_IWUSR),
broken_parity_status_show,broken_parity_status_store),
__ATTR(msi_bus, 0644, msi_bus_show, msi_bus_store),
+ __ATTR(block, 0200, NULL, block_store),
__ATTR_NULL,
};
next prev parent reply other threads:[~2006-10-17 14:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 14:51 [PATCH] Block on access to temporarily unavailable pci device Matthew Wilcox
2006-10-17 14:54 ` Matthew Wilcox [this message]
2006-10-17 21:25 ` Brian King
2006-10-18 14:38 ` [linux-pm] " Alan Stern
2006-10-18 14:51 ` Matthew Wilcox
2006-10-18 15:52 ` Alan Stern
2006-10-18 16:05 ` Alan Cox
2006-10-18 16:09 ` Matthew Wilcox
2006-10-18 16:42 ` Alan Cox
2006-10-18 14:51 ` Matthew Wilcox
2006-10-18 14:57 ` Matthew Wilcox
2006-10-18 15:12 ` Nick Piggin
2006-10-18 15:16 ` Matthew Wilcox
2006-10-18 15:27 ` Nick Piggin
2006-10-18 15:50 ` Alan Cox
2006-10-18 16:20 ` Matthew Wilcox
2006-10-18 16:39 ` Alan Cox
2006-10-18 17:14 ` Matthew Wilcox
2006-10-19 15:41 ` [PATCH] Block on access to temporarily unavailable pci device [version 3] Matthew Wilcox
2006-10-19 16:32 ` Alan Cox
2006-10-19 23:13 ` Adam Belay
2006-10-19 23:51 ` Greg KH
2006-10-20 21:50 ` Brian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061017145403.GK22289@parisc-linux.org \
--to=matthew@wil.cx \
--cc=abelay@MIT.EDU \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-pm@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox