public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] swsusp: fix platform mode
@ 2006-10-17 20:19 Stefan Seyfried
  0 siblings, 0 replies; only message in thread
From: Stefan Seyfried @ 2006-10-17 20:19 UTC (permalink / raw)
  To: linux-kernel; +Cc: Pavel Machek, Rafael J. Wysocki, Andrew Morton

At some point after 2.6.13, in-kernel software suspend got "incomplete"
for the so-called "platform" mode. pm_ops->prepare() is never called.
A visible sign of this is the "moon" light on thinkpads not flashing
during suspend. Fix by readding the pm_ops->prepare call during suspend.

Signed-off-by: Stefan Seyfried <seife@suse.de>
Acked-by: "Rafael J. Wysocki" <rjw@sisk.pl>
---

 kernel/power/disk.c |   22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

--- linux/kernel/power/disk.c	2006-09-20 05:42:06.000000000 +0200
+++ linux-2.6.18.patched/kernel/power/disk.c	2006-10-17 22:03:26.000000000 +0200
@@ -27,6 +27,22 @@ char resume_file[256] = CONFIG_PM_STD_PA
 dev_t swsusp_resume_device;
 
 /**
+ *	platform_prepare - prepare the machine for hibernation using the
+ *	platform driver if so configured and return an error code if it fails
+ */
+
+static inline int platform_prepare(void)
+{
+	int error = 0;
+
+	if (pm_disk_mode == PM_DISK_PLATFORM) {
+		if (pm_ops && pm_ops->prepare)
+			error = pm_ops->prepare(PM_SUSPEND_DISK);
+	}
+	return error;
+}
+
+/**
  *	power_down - Shut machine down for hibernate.
  *	@mode:		Suspend-to-disk mode
  *
@@ -79,9 +95,15 @@ static int prepare_processes(void)
 		goto thaw;
 	}
 
+	error = platform_prepare();
+	if (error)
+		goto thaw;
+
 	/* Free memory before shutting down devices. */
 	if (!(error = swsusp_shrink_memory()))
 		return 0;
+
+	platform_finish();
 thaw:
 	thaw_processes();
 	enable_nonboot_cpus();
-- 
Stefan Seyfried
QA / R&D Team Mobile Devices        |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg  | "Well, surrounding them's out." 

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-10-17 20:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-17 20:19 [PATCH] swsusp: fix platform mode Stefan Seyfried

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox