public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [DRM] fix return code in error case.
@ 2006-10-18  4:26 Dave Jones
  0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2006-10-18  4:26 UTC (permalink / raw)
  To: Linux Kernel; +Cc: airlied

The other failure returns in this function are negative, so make
this one do the same.

Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/drivers/char/drm/savage_state.c b/drivers/char/drm/savage_state.c
index ef2581d..1ca1e9c 100644
--- a/drivers/char/drm/savage_state.c
+++ b/drivers/char/drm/savage_state.c
@@ -994,7 +994,7 @@ int savage_bci_cmdbuf(DRM_IOCTL_ARGS)
 	if (cmdbuf.size) {
 		kcmd_addr = drm_alloc(cmdbuf.size * 8, DRM_MEM_DRIVER);
 		if (kcmd_addr == NULL)
-			return ENOMEM;
+			return DRM_ERR(ENOMEM);
 
 		if (DRM_COPY_FROM_USER(kcmd_addr, cmdbuf.cmd_addr,
 				       cmdbuf.size * 8))
diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c

-- 
http://www.codemonkey.org.uk

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2006-10-18  4:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-18  4:26 [DRM] fix return code in error case Dave Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox