public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* implicit declaration of function set_irq_chip_and_handler
@ 2006-10-18  8:04 Olaf Hering
  2006-10-18  8:16 ` [patch] genirq: clean up irq-flow-type naming, fix Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Olaf Hering @ 2006-10-18  8:04 UTC (permalink / raw)
  To: Ingo Molnar, linuxppc-dev, linux-kernel


Current Linus tree has two new warnings

arch/powerpc/kernel/irq.c: In function irq_dispose_mapping:
arch/powerpc/kernel/irq.c:642: warning: implicit declaration of function set_irq_chip_and_handler
arch/powerpc/sysdev/mpic.c: In function mpic_host_map:
arch/powerpc/sysdev/mpic.c:770: warning: implicit declaration of function set_irq_chip_and_handler

It links anyway for some reason.
There is no prototype anymore, but still many users.

a460e745e8f9c75a0525ff94154a0629f9d3e05d is likely the culprit:
 [PATCH] genirq: clean up irq-flow-type naming


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [patch] genirq: clean up irq-flow-type naming, fix
  2006-10-18  8:04 implicit declaration of function set_irq_chip_and_handler Olaf Hering
@ 2006-10-18  8:16 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2006-10-18  8:16 UTC (permalink / raw)
  To: Olaf Hering; +Cc: linuxppc-dev, linux-kernel, Andrew Morton


* Olaf Hering <olaf@aepfle.de> wrote:

> There is no prototype anymore, but still many users.
> 
> a460e745e8f9c75a0525ff94154a0629f9d3e05d is likely the culprit:
>  [PATCH] genirq: clean up irq-flow-type naming

oops, that was unintended. The patch below should fix this.

	Ingo

--------------->
Subject: genirq: clean up irq-flow-type naming, fix
From: Ingo Molnar <mingo@elte.hu>

re-add the set_irq_chip_and_handler() prototype, it's still widely used.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/irq.h |    3 +++
 1 file changed, 3 insertions(+)

Index: linux/include/linux/irq.h
===================================================================
--- linux.orig/include/linux/irq.h
+++ linux/include/linux/irq.h
@@ -322,6 +322,9 @@ extern struct irq_chip no_irq_chip;
 extern struct irq_chip dummy_irq_chip;
 
 extern void
+set_irq_chip_and_handler(unsigned int irq, struct irq_chip *chip,
+			 irq_flow_handler_t handle);
+extern void
 set_irq_chip_and_handler_name(unsigned int irq, struct irq_chip *chip,
 			      irq_flow_handler_t handle, const char *name);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-10-18  8:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-18  8:04 implicit declaration of function set_irq_chip_and_handler Olaf Hering
2006-10-18  8:16 ` [patch] genirq: clean up irq-flow-type naming, fix Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox