From: Jarek Poplawski <jarkao2@o2.pl>
To: Amit Choudhary <amit2030@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19-rc2] [REVISED] drivers/media/video/se401.c: check kmalloc() return value.
Date: Wed, 18 Oct 2006 10:29:32 +0200 [thread overview]
Message-ID: <20061018082931.GA2051@ff.dom.local> (raw)
In-Reply-To: <20061017213155.35983846.amit2030@gmail.com>
On 18-10-2006 06:31, Amit Choudhary wrote:
> Description: Check the return value of kmalloc() in function se401_start_stream(), in file drivers/media/video/se401.c.
>
> Signed-off-by: Amit Choudhary <amit2030@gmail.com>
>
> diff --git a/drivers/media/video/se401.c b/drivers/media/video/se401.c
> index 7aeec57..fe94227 100644
> --- a/drivers/media/video/se401.c
> +++ b/drivers/media/video/se401.c
> @@ -450,6 +450,8 @@ static int se401_start_stream(struct usb
> }
> for (i=0; i<SE401_NUMSBUF; i++) {
> se401->sbuf[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
> + if (!se401->sbuf[i].data)
> + goto nomem_err;
> }
>
> se401->bayeroffset=0;
> @@ -458,13 +460,15 @@ static int se401_start_stream(struct usb
> se401->scratch_overflow=0;
> for (i=0; i<SE401_NUMSCRATCH; i++) {
> se401->scratch[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
> + if (!se401->scratch[i].data)
> + goto nomem_err;
> se401->scratch[i].state=BUFFER_UNUSED;
> }
>
> for (i=0; i<SE401_NUMSBUF; i++) {
> urb=usb_alloc_urb(0, GFP_KERNEL);
> if(!urb)
> - return -ENOMEM;
> + goto nomem_err;
>
> usb_fill_bulk_urb(urb, se401->dev,
> usb_rcvbulkpipe(se401->dev, SE401_VIDEO_ENDPOINT),
> @@ -482,6 +486,20 @@ static int se401_start_stream(struct usb
> se401->framecount=0;
>
> return 0;
> +
> + nomem_err:
> + for (i=0; i<SE401_NUMSBUF; i++) {
> + usb_kill_urb(se401->urb[i]);
> + usb_free_urb(se401->urb[i]);
> + se401->urb[i] = NULL;
> + kfree(se401->sbuf[i].data);
...
I see before se401_start_stream usually this is done:
static int se401_stop_stream(struct usb_se401 *se401)
{
...
for (i=0; i<SE401_NUMSBUF; i++) if (se401->urb[i]) {
usb_kill_urb(se401->urb[i]);
usb_free_urb(se401->urb[i]);
se401->urb[i]=NULL;
kfree(se401->sbuf[i].data);
}
for (i=0; i<SE401_NUMSCRATCH; i++) {
kfree(se401->scratch[i].data);
se401->scratch[i].data=NULL;
}
return 0;
}
... but because above there is no:
se401->sbuf[i].data=NULL;
after kfree(se401->sbuf[i].data);
it is possible that in se401_start_stream we have
kmalloc error for e.g. i == 0 but kfree for i >= 1,
which could be not NULL (but kfreed)...
Regards,
Jarek P.
prev parent reply other threads:[~2006-10-18 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 4:31 [PATCH 2.6.19-rc2] [REVISED] drivers/media/video/se401.c: check kmalloc() return value Amit Choudhary
2006-10-18 8:29 ` Jarek Poplawski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018082931.GA2051@ff.dom.local \
--to=jarkao2@o2.pl \
--cc=amit2030@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox