From: Paul Jackson <pj@sgi.com>
To: akpm@osdl.org, Dinakar Guniguntala <dino@in.ibm.com>
Cc: Simon.Derr@bull.net, Paul Jackson <pj@sgi.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Cpuset: remove useless sched domain line
Date: Wed, 18 Oct 2006 02:09:03 -0700 [thread overview]
Message-ID: <20061018090903.13809.57883.sendpatchset@sam.engr.sgi.com> (raw)
From: Paul Jackson <pj@sgi.com>
Remove a useless line from the sched domain setup code in cpusets.
When I removed the 'is_removed()' flag test from the sched domain
setup code in cpusets, as part of my July 23, 2006 patch:
Cpuset: fix ABBA deadlock with cpu hotplug lock
I failed to notice that this opened the door to a little bit of code
simplification. A line of code that had to cover for the possibility
that a cpuset marked cpu_exclusive was marked for removal could
be eliminated. In the code section visible in this patch, it is
now the case that cur->cpus_allowed is always a subset of pspan,
so it is always a no-op to cpus_or() cur->cpus_allowed into pspan.
Signed-off-by: Paul Jackson <pj@sgi.com>
---
Resending what I just sent an hour ago - this time with akpm
on the "To" list, like I meant to the first time.
I believe this is ready for *-mm.
-pj
kernel/cpuset.c | 1 -
1 files changed, 1 deletion(-)
--- 2.6.19-rc1-mm1.orig/kernel/cpuset.c 2006-10-13 21:31:16.000000000 -0700
+++ 2.6.19-rc1-mm1/kernel/cpuset.c 2006-10-13 21:32:20.000000000 -0700
@@ -783,7 +783,6 @@ static void update_cpu_domains(struct cp
cpus_andnot(pspan, pspan, c->cpus_allowed);
}
if (!is_cpu_exclusive(cur)) {
- cpus_or(pspan, pspan, cur->cpus_allowed);
if (cpus_equal(pspan, cur->cpus_allowed))
return;
cspan = CPU_MASK_NONE;
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next reply other threads:[~2006-10-18 9:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 9:09 Paul Jackson [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-10-18 8:14 [PATCH] Cpuset: remove useless sched domain line Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061018090903.13809.57883.sendpatchset@sam.engr.sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox