* [PATCH] Make <linux/personality.h> userspace proof
@ 2006-10-17 15:55 Ralf Baechle
2006-10-18 10:24 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2006-10-17 15:55 UTC (permalink / raw)
To: Andrew Morton, linux-kernel
<linux/personality.h> contains the constants for personality(2) but also
some defintions that are useless or even harmful in userspace such as
the personality() macro.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
include/linux/personality.h | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/linux/personality.h b/include/linux/personality.h
index 80d780e..bf4cf20 100644
--- a/include/linux/personality.h
+++ b/include/linux/personality.h
@@ -1,6 +1,8 @@
#ifndef _LINUX_PERSONALITY_H
#define _LINUX_PERSONALITY_H
+#ifdef __KERNEL__
+
/*
* Handling of different ABIs (personalities).
*/
@@ -12,6 +14,8 @@ extern int register_exec_domain(struct
extern int unregister_exec_domain(struct exec_domain *);
extern int __set_personality(unsigned long);
+#endif /* __KERNEL__ */
+
/*
* Flags for bug emulation.
*
@@ -71,6 +75,7 @@ enum {
PER_MASK = 0x00ff,
};
+#ifdef __KERNEL__
/*
* Description of an execution domain.
@@ -111,4 +116,6 @@ #define get_personality (current->perso
#define set_personality(pers) \
((current->personality == pers) ? 0 : __set_personality(pers))
+#endif /* __KERNEL__ */
+
#endif /* _LINUX_PERSONALITY_H */
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Make <linux/personality.h> userspace proof
2006-10-17 15:55 [PATCH] Make <linux/personality.h> userspace proof Ralf Baechle
@ 2006-10-18 10:24 ` Christoph Hellwig
2006-10-18 10:32 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2006-10-18 10:24 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Morton, linux-kernel
On Tue, Oct 17, 2006 at 04:55:26PM +0100, Ralf Baechle wrote:
> <linux/personality.h> contains the constants for personality(2) but also
> some defintions that are useless or even harmful in userspace such as
> the personality() macro.
NACK. glibc has a <sys/personality.h> for that. It's been there since
at least glibc 2.3.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Make <linux/personality.h> userspace proof
2006-10-18 10:24 ` Christoph Hellwig
@ 2006-10-18 10:32 ` Ralf Baechle
0 siblings, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2006-10-18 10:32 UTC (permalink / raw)
To: Christoph Hellwig, Andrew Morton, linux-kernel
On Wed, Oct 18, 2006 at 11:24:33AM +0100, Christoph Hellwig wrote:
> On Tue, Oct 17, 2006 at 04:55:26PM +0100, Ralf Baechle wrote:
> > <linux/personality.h> contains the constants for personality(2) but also
> > some defintions that are useless or even harmful in userspace such as
> > the personality() macro.
>
> NACK. glibc has a <sys/personality.h> for that. It's been there since
> at least glibc 2.3.
And I ran over this on a glibc 2.2 system ...
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-18 10:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-17 15:55 [PATCH] Make <linux/personality.h> userspace proof Ralf Baechle
2006-10-18 10:24 ` Christoph Hellwig
2006-10-18 10:32 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox