From: Anton Vorontsov No need to get_device(driverfs_dev), because it's already gotten by add_disk(). And no function will call put_device() second time. This is the source of deadlock[1] in IDE layer. SCSI workaround it by calling put_device() themself after put_disk(), thus it should reflect this change by removing put_device(). [1] deadlock in ide_unregister() at wait_for_completion(&drive->gendev_rel_comp) after device_unregister(&drive->gendev). That happens by reason of ide-probe.c:drive_release_dev() not called because of driverfs_dev (which is drive->gendev) still referenced by add_disk(). diff --git a/fs/partitions/check.c b/fs/partitions/check.c index 6fb4b61..8371adf 100644 --- a/fs/partitions/check.c +++ b/fs/partitions/check.c @@ -378,7 +378,7 @@ static char *make_block_name(struct gend static int disk_sysfs_symlinks(struct gendisk *disk) { - struct device *target = get_device(disk->driverfs_dev); + struct device *target = disk->driverfs_dev; int err; char *disk_name = NULL; @@ -414,9 +414,8 @@ err_out_dev_link: sysfs_remove_link(&disk->kobj, "device"); err_out_disk_name: kfree(disk_name); -err_out: - put_device(target); } +err_out: return err; } diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 84ff203..03dca98 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -1760,7 +1760,6 @@ static void scsi_disk_release(struct cla disk->private_data = NULL; put_disk(disk); - put_device(&sdkp->device->sdev_gendev); kfree(sdkp); }