From: Al Viro <viro@ftp.linux.org.uk>
To: Neil Brown <neilb@suse.de>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHSET] nfs endianness annotations
Date: Thu, 19 Oct 2006 02:26:00 +0100 [thread overview]
Message-ID: <20061019012600.GR29920@ftp.linux.org.uk> (raw)
In-Reply-To: <17718.51050.186385.512984@cse.unsw.edu.au>
On Thu, Oct 19, 2006 at 10:31:38AM +1000, Neil Brown wrote:
> > ACK on patches # 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12. I'd be quite happy
> > to get those into mainline ASAP.
> >
> > I'll defer to Neil for the rest.
>
> Thanks for the reminder Trond.
>
> Yes,
>
> Acked-By: NeilBrown <neilb@suse.de>
>
> for 1, 13-25.
> Thanks for doing this - there are some important cleanups in there,
> particular the clear differentiation between err and host_err (not to
> mention the bug fixes!).
err vs. host_err was pretty much the main reason for that series - we kept
getting bugs in that area and sparse can handle that sort of checks just
fine.
Folks, seriously, please run sparse after changes; it's a simple matter of
make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; nothing tricky and it saves a lot
of potential PITA...
next prev parent reply other threads:[~2006-10-19 1:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1GX7zV-00047C-PO@ZenIV.linux.org.uk>
2006-10-18 21:26 ` [PATCHSET] nfs endianness annotations Trond Myklebust
2006-10-19 0:31 ` Neil Brown
2006-10-19 1:26 ` Al Viro [this message]
2006-10-19 2:55 ` Neil Brown
2006-10-19 5:30 ` Grant Coady
2006-10-19 6:32 ` Neil Brown
2006-10-19 23:22 ` Randy Dunlap
2006-10-19 11:49 ` Al Viro
2006-10-10 3:10 Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019012600.GR29920@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox