Re: [PATCHSET] nfs endianness annotations

Al Viro
2006-10-19T01:26:04Z

On Thu, Oct 19, 2006 at 10:31:38AM +1000, Neil Brown wrote:
> > ACK on patches # 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12. I'd be quite happy
> > to get those into mainline ASAP.
> >
> > I'll defer to Neil for the rest.
>
> Thanks for the reminder Trond.
>
> Yes,
>
> Acked-By: NeilBrown <neilb@suse.de>
>
> for 1, 13-25.
> Thanks for doing this - there are some important cleanups in there,
> particular the clear differentiation between err and host_err (not to
> mention the bug fixes!).

err vs. host_err was pretty much the main reason for that series - we kept
getting bugs in that area and sparse can handle that sort of checks just
fine.

Folks, seriously, please run sparse after changes; it's a simple matter of
make C=2 CF=-D__CHECK_ENDIAN__ fs/nfs*/; nothing tricky and it saves a lot
of potential PITA...