From: Paul Jackson <pj@sgi.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Martin Bligh <mbligh@google.com>, Paul Menage <menage@google.com>,
Simon.Derr@bull.net, linux-kernel@vger.kernel.org,
Dinakar Guniguntala <dino@in.ibm.com>,
Rohit Seth <rohitseth@google.com>, Robin Holt <holt@sgi.com>,
dipankar@in.ibm.com, Nick Piggin <nickpiggin@yahoo.com.au>,
Paul Jackson <pj@sgi.com>,
"Siddha, Suresh B" <suresh.b.siddha@intel.com>
Subject: [PATCH] cpuset: minor code refinements
Date: Thu, 19 Oct 2006 02:21:50 -0700 [thread overview]
Message-ID: <20061019092150.17547.50354.sendpatchset@sam.engr.sgi.com> (raw)
From: Paul Jackson <pj@sgi.com>
A couple of minor code simplifications to the
kernel/cpuset.c code. No functional change.
Just a little less code and a little more readable.
Signed-off-by: Paul Jackson <pj@sgi.com>
---
kernel/cpuset.c | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
--- 2.6.19-rc1-mm1.orig/kernel/cpuset.c 2006-10-19 01:06:29.000000000 -0700
+++ 2.6.19-rc1-mm1/kernel/cpuset.c 2006-10-19 01:06:49.000000000 -0700
@@ -729,9 +729,11 @@ static int validate_change(const struct
}
/* Remaining checks don't apply to root cpuset */
- if ((par = cur->parent) == NULL)
+ if (cur == &top_cpuset)
return 0;
+ par = cur->parent;
+
/* We must be a subset of our parent cpuset */
if (!is_cpuset_subset(trial, par))
return -EACCES;
@@ -1060,10 +1062,7 @@ static int update_flag(cpuset_flagbits_t
cpu_exclusive_changed =
(is_cpu_exclusive(cs) != is_cpu_exclusive(&trialcs));
mutex_lock(&callback_mutex);
- if (turning_on)
- set_bit(bit, &cs->flags);
- else
- clear_bit(bit, &cs->flags);
+ cs->flags = trialcs.flags;
mutex_unlock(&callback_mutex);
if (cpu_exclusive_changed)
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
reply other threads:[~2006-10-19 9:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019092150.17547.50354.sendpatchset@sam.engr.sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=dipankar@in.ibm.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=menage@google.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rohitseth@google.com \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox