Re: fs/Kconfig question regarding CONFIG_BLOCK

[Jens Axboe <jens.axboe@oracle.com>]

On Wed, Oct 18 2006, Randy Dunlap wrote:
> On Wed, 18 Oct 2006 09:09:22 +0200 Jens Axboe wrote:
> 
> > On Tue, Oct 17 2006, Jan Engelhardt wrote:
> > > >> Never mind, I see that some filesystems have 'depends on BLOCK' instead 
> > > >> of being wrapped into if BLOCK. Not really consistent but whatever.
> > > >
> > > >Feel free to send in patches that make things more consistent.
> > > 
> > > How would you like things? if BLOCK or depends on BLOCK?
> > 
> > Well, if you can hide an entire block with if BLOCK, then that would be
> > preferred. Otherwise depends on BLOCK.
> > 
> > > Does menuconfig/oldconfig/etc. parse the whole config structure faster 
> > > it it done either way?
> > 
> > I'd be surprised if if BLOCK wasn't faster over, say, 10 depends on
> > BLOCK.
> 
> Jens,
> Has anyone looked at what BLOCK=n does to mm/page-writeback.c ?
> It calls blk_congestion_end(), which isn't there.
> 
> mm/built-in.o: In function `writeback_congestion_end':
> (.text.writeback_congestion_end+0xc): undefined reference to `blk_congestion_end'
> make: *** [.tmp_vmlinux1] Error 1
> Command exited with non-zero status 2

Yeah currently known, with Andrew's latest we should be getting closer.

-- 
Jens Axboe