From: "Siddha, Suresh B" <suresh.b.siddha@intel.com>
To: Christoph Lameter <clameter@sgi.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
Nick Piggin <nickpiggin@yahoo.com.au>,
Ingo Molnar <mingo@elte.hu>,
Peter Williams <pwil3058@bigpond.net.au>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] sched_tick with interrupts enabled
Date: Thu, 19 Oct 2006 13:40:46 -0700 [thread overview]
Message-ID: <20061019134046.A2305@unix-os.sc.intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0610190736210.7337@schroedinger.engr.sgi.com>; from clameter@sgi.com on Thu, Oct 19, 2006 at 08:50:50AM -0700
On Thu, Oct 19, 2006 at 08:50:50AM -0700, Christoph Lameter wrote:
> Ok. Thanks. Would this work?
>
> Index: linux-2.6.19-rc2-mm1/kernel/sched.c
> ===================================================================
> --- linux-2.6.19-rc2-mm1.orig/kernel/sched.c 2006-10-19 09:39:08.000000000 -0500
> +++ linux-2.6.19-rc2-mm1/kernel/sched.c 2006-10-19 09:42:10.733631242 -0500
> @@ -2846,7 +2846,8 @@ static void rebalance_tick(unsigned long
> struct sched_domain *sd;
> int i, scale;
>
> - idle = (current == this_rq->idle) ? SCHED_IDLE : NOT_IDLE;
> + idle = (current == this_rq->idle && !this_rq->nr_running) ?
> + SCHED_IDLE : NOT_IDLE;
A comment of why we are checking for nr_running would be nice.
And one more thing. We can reduce some of the tasklet invoking complexity
by actually checking for a load_balance() need at any domain and thus
invoking tasklet which will do the load balance, rather than unconditionally
invoking tasklet for each tick.
thanks,
suresh
prev parent reply other threads:[~2006-10-19 21:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 17:04 [RFC] sched_tick with interrupts enabled Christoph Lameter
2006-10-18 17:21 ` Nick Piggin
2006-10-18 18:01 ` Christoph Lameter
2006-10-18 18:09 ` Nick Piggin
2006-10-18 18:48 ` Christoph Lameter
2006-10-18 19:14 ` Nick Piggin
2006-10-18 21:59 ` Christoph Lameter
2006-10-19 2:19 ` Siddha, Suresh B
2006-10-19 10:16 ` KAMEZAWA Hiroyuki
2006-10-19 15:50 ` Christoph Lameter
2006-10-19 20:40 ` Siddha, Suresh B [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019134046.A2305@unix-os.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pwil3058@bigpond.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox