Re: [PATCH] Block on access to temporarily unavailable pci device

Nick Piggin
2006-10-18T15:12:48Z

Matthew Wilcox wrote:

> I also addressed the potential issue with nested attempts to block.
> Now pci_block_user_cfg_access() can return -EBUSY if it's already blocked,
> and pci_unblock_user_cfg_access() will WARN if you try to unblock an
> already unblocked device.

Why not just WARN if it is already blocked as well? Presumably if the
driver needs nested blocking, it is going to have to carry some state
to know when to do the final unblock anyway, so it may as well just
not do these redundant blocks either.

** or ** just do a counting block/unblock to properly support nesting
them. That is, go one way or the other, and do it properly.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com