From: Andi Kleen <ak@suse.de>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] account_system_vtime() should be a macro, not a function
Date: Thu, 19 Oct 2006 15:46:02 +0200 [thread overview]
Message-ID: <200610191546.02566.ak@suse.de> (raw)
In-Reply-To: <200610191543.18951.dada1@cosmosbay.com>
On Thursday 19 October 2006 15:43, Eric Dumazet wrote:
> [PATCH] account_system_vtime() should be a macro, not a function
>
> Because the way 'current' is implemented on some archs, it's better to use a
> null macro for account_system_vtime(current)
>
> I discovered that gcc was (correctly) issuing one useless instruction (to
> load %rax with current from pda) on x86_64 on irq_enter() and __irq_exit()
>
> This saves few bytes in kernel size, on archs where current is 'asm volatile'
I dropped the asm volatile on x86-64 some time ago. Perhaps it should
be dropped on the other architectures too. Then such hacks wouldn't
be needed anywhere.
-Andi
prev parent reply other threads:[~2006-10-19 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-17 15:47 [Bug 185] Sometimes kernel freezes sometime lists OOPS - hostap_cs CIJOML
2006-10-19 6:56 ` Andrew Morton
2006-10-19 8:12 ` CIJOML
2006-10-19 8:44 ` Andrew Morton
2006-10-19 9:51 ` CIJOML
2006-10-19 13:43 ` [PATCH] account_system_vtime() should be a macro, not a function Eric Dumazet
2006-10-19 13:46 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610191546.02566.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox