From: Andi Kleen <ak@suse.de>
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-kernel@vger.kernel.org, johnstul@us.ibm.com, mingo@elte.hu,
tglx@linutronix.de
Subject: Re: + i386-time-avoid-pit-smp-lockups.patch added to -mm tree
Date: Thu, 19 Oct 2006 15:47:09 +0200 [thread overview]
Message-ID: <200610191547.09640.ak@suse.de> (raw)
In-Reply-To: <1161265475.11264.7.camel@c-67-180-230-165.hsd1.ca.comcast.net>
On Thursday 19 October 2006 15:44, Daniel Walker wrote:
> On Wed, 2006-10-11 at 14:26 -0700, akpm@osdl.org wrote:
>
> > diff -puN arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups arch/i386/kernel/i8253.c
> > --- a/arch/i386/kernel/i8253.c~i386-time-avoid-pit-smp-lockups
> > +++ a/arch/i386/kernel/i8253.c
> > @@ -109,7 +109,7 @@ static struct clocksource clocksource_pi
> >
> > static int __init init_pit_clocksource(void)
> > {
> > - if (num_possible_cpus() > 4) /* PIT does not scale! */
> > + if (num_possible_cpus() > 1) /* PIT does not scale! */
> > return 0;
> >
>
> Can we ifdef some code here on CONFIG_SMP . It bugs me that there just
> dead code laying around on smp systems.
The optimizer should optimize it all out since num_possible_cpus() is a 0
constant on UP.
-Andi
next prev parent reply other threads:[~2006-10-19 13:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200610112126.k9BLQqKG002529@shell0.pdx.osdl.net>
2006-10-19 13:44 ` + i386-time-avoid-pit-smp-lockups.patch added to -mm tree Daniel Walker
2006-10-19 13:47 ` Andi Kleen [this message]
2006-10-19 13:57 ` Daniel Walker
2006-10-19 14:05 ` Andi Kleen
2006-10-19 14:50 ` Daniel Walker
2006-10-19 14:22 ` Nick Piggin
2006-10-19 14:26 ` Andi Kleen
2006-10-19 14:48 ` Nick Piggin
2006-10-19 14:50 ` Andi Kleen
2006-10-19 15:01 ` Daniel Walker
2006-10-19 18:27 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610191547.09640.ak@suse.de \
--to=ak@suse.de \
--cc=dwalker@mvista.com \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox