From: Christoph Hellwig <hch@infradead.org>
To: Vasily Tarasov <vtaras@openvz.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jan Kara <jack@suse.cz>,
Dmitry Mishin <dim@openvz.org>, Vasily Averin <vvs@sw.ru>,
Kirill Korotaev <dev@openvz.org>,
OpenVZ Developers List <devel@openvz.org>
Subject: Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
Date: Thu, 19 Oct 2006 18:29:49 +0100 [thread overview]
Message-ID: <20061019172948.GA30975@infradead.org> (raw)
In-Reply-To: <200610191232.k9JCW7CF015486@vass.7ka.mipt.ru>
On Thu, Oct 19, 2006 at 04:32:07PM +0400, Vasily Tarasov wrote:
> +asmlinkage long sys32_quotactl(unsigned int cmd, const char __user *special,
> + qid_t id, void __user *addr)
> +{
> + long ret;
> + unsigned int cmds;
> + mm_segment_t old_fs;
> + struct if_dqblk dqblk;
> + struct if32_dqblk {
> + __u32 dqb_bhardlimit[2];
> + __u32 dqb_bsoftlimit[2];
> + __u32 dqb_curspace[2];
> + __u32 dqb_ihardlimit[2];
> + __u32 dqb_isoftlimit[2];
> + __u32 dqb_curinodes[2];
> + __u32 dqb_btime[2];
> + __u32 dqb_itime[2];
> + __u32 dqb_valid;
> + } dqblk32;
> +
> + cmds = cmd >> SUBCMDSHIFT;
> +
> + switch (cmds) {
> + case Q_GETQUOTA:
> + old_fs = get_fs();
> + set_fs(KERNEL_DS);
> + ret = sys_quotactl(cmd, special, id, &dqblk);
> + set_fs(old_fs);
Please allocate the structure using compat_alloc_userspace and copy
with copy_in_user instead of the set_fs trick.
next prev parent reply other threads:[~2006-10-19 17:29 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 12:32 [PATCH] diskquota: 32bit quota tools on 64bit architectures Vasily Tarasov
2006-10-19 13:06 ` Alan Cox
2006-10-19 15:22 ` Randy Dunlap
2006-10-19 16:09 ` Andi Kleen
2006-10-20 6:30 ` Vasily Tarasov
2006-10-20 7:12 ` Christoph Hellwig
2006-10-20 12:21 ` Andi Kleen
2006-10-19 17:29 ` Christoph Hellwig [this message]
2006-10-20 6:10 ` Vasily Tarasov
2006-10-21 16:28 ` Arnd Bergmann
2006-10-23 2:12 ` David Chinner
2006-10-23 10:51 ` Vasily Tarasov
-- strict thread matches above, loose matches on Subject: below --
2006-10-20 5:59 Vasily Tarasov
2006-10-25 10:03 Vasily Tarasov
2006-10-25 11:03 ` Arnd Bergmann
2006-10-25 11:25 ` Vasily Tarasov
2006-10-25 11:50 ` Arnd Bergmann
2007-06-15 8:59 Vasily Tarasov
2007-06-15 9:01 Vasily Tarasov
2007-06-15 10:03 Mikael Pettersson
2007-06-15 10:41 ` Vasily Tarasov
2007-06-15 10:43 ` Arnd Bergmann
2007-06-15 11:00 ` Vasily Tarasov
2007-06-15 14:48 ` Vasily Tarasov
2007-06-15 15:24 ` Arnd Bergmann
2007-06-18 7:41 ` Vasily Tarasov
2007-06-15 11:08 Mikael Pettersson
2007-06-18 8:21 Vasily Tarasov
2007-06-19 19:33 ` Andrew Morton
2007-06-19 20:09 ` Mikael Pettersson
2007-06-19 22:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019172948.GA30975@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=dim@openvz.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=vtaras@openvz.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox