From: Olof Johansson <olof@lixom.net>
To: Peter Korsgaard <jacmet@sunsite.dk>
Cc: rmk+serial@arm.linux.org.uk, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] Xilinx uartlite serial driver
Date: Thu, 19 Oct 2006 18:06:59 -0500 [thread overview]
Message-ID: <20061019180659.200d7763@pb15> (raw)
In-Reply-To: <871wqfyjgi.fsf@slug.be.48ers.dk>
On Wed, 13 Sep 2006 15:39:09 +0200 Peter Korsgaard <jacmet@sunsite.dk> wrote:
> +static int __devinit ulite_probe(struct platform_device *pdev)
[...]
> + port = &ports[pdev->id];
> +
> + port->fifosize = 16;
> + port->regshift = 2;
> + port->iotype = UPIO_MEM;
> + port->iobase = 1; /* mark port in use */
> + port->mapbase = res->start;
> + port->membase = 0;
> + port->ops = &ulite_ops;
> + port->irq = res2->start;
> + port->flags = UPF_BOOT_AUTOCONF;
> + port->dev = &pdev->dev;
> + port->type = PORT_UNKNOWN;
Hi Peter,
You never fill in the 'line' member here, so probing of a second
uartlite port will fail.
Add:
port->line = pdev->id;
-Olof
next prev parent reply other threads:[~2006-10-19 23:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ac9o3ak3.fsf@sleipner.barco.com>
2006-08-22 15:13 ` [RFC][PATCH] Xilinx uartlite serial driver Peter Korsgaard
2006-09-12 14:33 ` Olof Johansson
2006-09-13 5:56 ` Peter Korsgaard
2006-09-13 13:39 ` Peter Korsgaard
2006-09-13 15:01 ` Olof Johansson
2006-10-19 23:06 ` Olof Johansson [this message]
2006-10-20 12:22 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019180659.200d7763@pb15 \
--to=olof@lixom.net \
--cc=jacmet@sunsite.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox