From: Matthew Wilcox <matthew@wil.cx>
To: David KOENIG <karhudever@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@lists.osdl.org
Subject: Re: [KJ] [PATCH] Replaced tty->driver_data lines with pci_get_drvdata(tty);
Date: Thu, 19 Oct 2006 13:19:53 -0600 [thread overview]
Message-ID: <20061019191953.GL2602@parisc-linux.org> (raw)
In-Reply-To: <4537CBE3.4080809@gmail.com>
On Thu, Oct 19, 2006 at 12:02:59PM -0700, David KOENIG wrote:
> +++ b/fs/compat_ioctl.c
> @@ -1270,7 +1270,7 @@ static int do_kdfontop_ioctl(unsigned in
> return -EPERM;
> op.data = compat_ptr(((struct console_font_op32 *)&op)->data);
> op.flags |= KD_FONT_FLAG_OLD;
> - - vc = ((struct tty_struct *)file->private_data)->driver_data;
> + vc = pci_get_drvdata((struct tty_struct *)file->private_data);
Did you even compile this? pci_get_drvdata doesn't take a struct
tty_struct *, it takes a struct pci_dev *.
prev parent reply other threads:[~2006-10-19 19:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 19:02 [PATCH] Replaced tty->driver_data lines with pci_get_drvdata(tty); David KOENIG
2006-10-19 19:19 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061019191953.GL2602@parisc-linux.org \
--to=matthew@wil.cx \
--cc=karhudever@gmail.com \
--cc=kernel-janitors@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox