From: Akinobu Mita <akinobu.mita@gmail.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: linux-kernel@vger.kernel.org, Antonino Daplas <adaplas@pol.net>
Subject: Re: [PATCH 3/6] video: use bitrev8
Date: Fri, 20 Oct 2006 11:48:27 +0900 [thread overview]
Message-ID: <20061020024827.GA6344@localhost> (raw)
In-Reply-To: <4537458D.4050107@tls.msk.ru>
On Thu, Oct 19, 2006 at 01:29:49PM +0400, Michael Tokarev wrote:
> > static inline void reverse_order(u32 *l)
> > {
> > u8 *a = (u8 *)l;
> > - *a = byte_rev[*a], a++;
> > - *a = byte_rev[*a], a++;
> > - *a = byte_rev[*a], a++;
> > - *a = byte_rev[*a];
> > + a[0] = bitrev8(a[0]);
> > + a[1] = bitrev8(a[1]);
> > + a[2] = bitrev8(a[2]);
> > + a[3] = bitrev8(a[3]);
> > }
>
> This looks like a good candidate for a common helper function, too.
I thought that and we already have static function bytereverse()
in lib/crc32. But I could not find where I could replace except here.
So I didn't put bytereverse() into bitrev.h
prev parent reply other threads:[~2006-10-20 2:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-18 16:44 [PATCH 3/6] video: use bitrev8 Akinobu Mita
2006-10-19 9:29 ` Michael Tokarev
2006-10-20 2:48 ` Akinobu Mita [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020024827.GA6344@localhost \
--to=akinobu.mita@gmail.com \
--cc=adaplas@pol.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox