From: Matthew Wilcox <matthew@wil.cx>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Minor fixes to generic do_div
Date: Thu, 19 Oct 2006 23:36:38 -0600 [thread overview]
Message-ID: <20061020053638.GS2602@parisc-linux.org> (raw)
In-Reply-To: <20061019215954.1be82a57.akpm@osdl.org>
On Thu, Oct 19, 2006 at 09:59:54PM -0700, Andrew Morton wrote:
> Can we use typecheck(), from include/linux/kernel.h?
I don't know.
It's copied and pasted from down below, so possibly this was
intentionally not used. or possibly the author didn't know about
typecheck().
If we do use it, we either have to include linux/kernel.h in
asm-generic/div64.h, which drags in a slew of includes of its own, or be
sure that all users already include kernel.h. i bet they do.
My allmodconfig build is currently testing out the
remove-sched.h-from-asm-parisc-uaccess.h patch based on viro's x86-64
patch seen earlier today, so I won't be testing the second hypothesis
tonight. Anyone want to try plugging in typecheck() and seeing if
anything breaks? NB: you'll want to be sure your arch is using
asm-generic/div64, or add the typecheck() to your arch's
asm-foo/div64.h.
We should probably do that anyway, at least for i386. And then someone
else would maybe wonder what the xtensa port is up to.
next prev parent reply other threads:[~2006-10-20 5:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 3:34 [PATCH] Minor fixes to generic do_div Matthew Wilcox
2006-10-20 4:59 ` Andrew Morton
2006-10-20 5:36 ` Matthew Wilcox [this message]
2006-10-20 5:49 ` Andrew Morton
2006-10-23 7:49 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020053638.GS2602@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox