From: Andi Kleen <ak@suse.de>
To: Vasily Tarasov <vtaras@openvz.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Jan Kara <jack@suse.cz>,
Dmitry Mishin <dim@openvz.org>, Vasily Averin <vvs@sw.ru>,
Kirill Korotaev <dev@openvz.org>,
OpenVZ Developers List <devel@openvz.org>
Subject: Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures
Date: Fri, 20 Oct 2006 14:21:43 +0200 [thread overview]
Message-ID: <200610201421.43611.ak@suse.de> (raw)
In-Reply-To: <200610200630.k9K6U4RU031798@vass.7ka.mipt.ru>
On Friday 20 October 2006 08:30, Vasily Tarasov wrote:
> Andi Kleen wrote:
>
> <snip>
> > Thanks. But the code should be probably common somewhere in fs/*, not
> > duplicated.
> <snip>
>
> Thank you for the comment!
> I'm not sure we should do it. If we move the code in fs/quota.c for example,
> than this code will be compiled for _all_ arhitectures, not only for x86_64 and ia64.
> Of course, we can surround this code by #ifdefs <ARCH>, but I thought this is
> a bad style... Moreover looking through current kernel code, I found out that
> usually code is duplicated in such cases.
Well it doesn't hurt them even if not strictly needed and it's better to have common code for
this. BTW you have to convert over to compat_alloc_* for this as Christoph stated
because set_fs doesn't work on all architectures. Best you use the compat_* types too.
-Andi
next prev parent reply other threads:[~2006-10-20 12:22 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 12:32 [PATCH] diskquota: 32bit quota tools on 64bit architectures Vasily Tarasov
2006-10-19 13:06 ` Alan Cox
2006-10-19 15:22 ` Randy Dunlap
2006-10-19 16:09 ` Andi Kleen
2006-10-20 6:30 ` Vasily Tarasov
2006-10-20 7:12 ` Christoph Hellwig
2006-10-20 12:21 ` Andi Kleen [this message]
2006-10-19 17:29 ` Christoph Hellwig
2006-10-20 6:10 ` Vasily Tarasov
2006-10-21 16:28 ` Arnd Bergmann
2006-10-23 2:12 ` David Chinner
2006-10-23 10:51 ` Vasily Tarasov
-- strict thread matches above, loose matches on Subject: below --
2006-10-20 5:59 Vasily Tarasov
2006-10-25 10:03 Vasily Tarasov
2006-10-25 11:03 ` Arnd Bergmann
2006-10-25 11:25 ` Vasily Tarasov
2006-10-25 11:50 ` Arnd Bergmann
2007-06-15 8:59 Vasily Tarasov
2007-06-15 9:01 Vasily Tarasov
2007-06-15 10:03 Mikael Pettersson
2007-06-15 10:41 ` Vasily Tarasov
2007-06-15 10:43 ` Arnd Bergmann
2007-06-15 11:00 ` Vasily Tarasov
2007-06-15 14:48 ` Vasily Tarasov
2007-06-15 15:24 ` Arnd Bergmann
2007-06-18 7:41 ` Vasily Tarasov
2007-06-15 11:08 Mikael Pettersson
2007-06-18 8:21 Vasily Tarasov
2007-06-19 19:33 ` Andrew Morton
2007-06-19 20:09 ` Mikael Pettersson
2007-06-19 22:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200610201421.43611.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=dim@openvz.org \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=vtaras@openvz.org \
--cc=vvs@sw.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox