From: Daniel Walker <dwalker@mvista.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Auke Kok <auke-jan.h.kok@intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] e100_shutdown: netif_poll_disable hang
Date: Fri, 20 Oct 2006 11:28:20 -0700 [thread overview]
Message-ID: <20061020182820.978932000@mvista.com> (raw)
My machine annoyingly hangs while rebooting. I tracked it down
to e100-fix-reboot-f-with-netconsole-enabled.patch in 2.6.18-rc2-mm2
I review the changes and it seemed to be calling netif_poll_disable
one too many time. Once in e100_down(), and again in e100_shutdown().
The second one in e100_shutdown() caused the hang. So this patch
removes it.
Signed-Off-By: Daniel Walker <dwalker@mvista.com>
---
drivers/net/e100.c | 1 -
1 files changed, 1 deletion(-)
Index: linux-2.6.18/drivers/net/e100.c
===================================================================
--- linux-2.6.18.orig/drivers/net/e100.c
+++ linux-2.6.18/drivers/net/e100.c
@@ -2709,7 +2709,6 @@ static void e100_shutdown(struct pci_dev
struct net_device *netdev = pci_get_drvdata(pdev);
struct nic *nic = netdev_priv(netdev);
- netif_poll_disable(nic->netdev);
del_timer_sync(&nic->watchdog);
netif_carrier_off(nic->netdev);
--
next reply other threads:[~2006-10-20 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-20 18:28 Daniel Walker [this message]
2006-10-20 20:51 ` [PATCH] e100_shutdown: netif_poll_disable hang Auke Kok
2006-10-20 21:09 ` Auke Kok
2006-10-21 17:41 ` Damien Wyart
2006-10-21 17:54 ` Auke Kok
2006-10-21 20:55 ` Damien Wyart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020182820.978932000@mvista.com \
--to=dwalker@mvista.com \
--cc=akpm@osdl.org \
--cc=auke-jan.h.kok@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox