From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: switch to new pci_get_bus_and_slot API
Date: Fri, 20 Oct 2006 20:17:11 +0100 [thread overview]
Message-ID: <20061020191711.GD8894@flint.arm.linux.org.uk> (raw)
In-Reply-To: <1161013790.24237.97.camel@localhost.localdomain>
On Mon, Oct 16, 2006 at 04:49:50PM +0100, Alan Cox wrote:
> Signed-off-by: Alan Cox <alan@redhat.com>
Applied a while back, but just discovered these in the ARM kautobuild
logs...
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.19-rc1-mm1/arch/arm/mach-ixp2000/ixdp2400.c linux-2.6.19-rc1-mm1/arch/arm/mach-ixp2000/ixdp2400.c
> --- linux.vanilla-2.6.19-rc1-mm1/arch/arm/mach-ixp2000/ixdp2400.c 2006-10-13 15:06:14.000000000 +0100
> +++ linux-2.6.19-rc1-mm1/arch/arm/mach-ixp2000/ixdp2400.c 2006-10-13 17:14:23.000000000 +0100
> @@ -133,11 +133,13 @@
> struct pci_dev *dev;
>
> if (ixdp2x00_master_npu()) {
> - dev = pci_find_slot(1, IXDP2400_SLAVE_ENET_DEVFN);
> + dev = pci_get_bus_and_slot(1, IXDP2400_SLAVE_ENET_DEVFN);
> pci_remove_bus_device(dev);
> + pci_dev_put(dev)
Missing ;
> } else {
> - dev = pci_find_slot(1, IXDP2400_MASTER_ENET_DEVFN);
> + dev = pci_get_bus_and_slot(1, IXDP2400_MASTER_ENET_DEVFN);
> pci_remove_bus_device(dev);
> + pci_dev_put(dev)
Missing ;
Now fixed in my tree.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2006-10-20 19:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-16 15:49 [PATCH] arm: switch to new pci_get_bus_and_slot API Alan Cox
2006-10-20 19:17 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061020191711.GD8894@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox