* 2.6.19-rc2-mm2 not building on ia64
@ 2006-10-20 20:57 Bryce Harrington
2006-10-20 22:14 ` Jiri Kosina
0 siblings, 1 reply; 3+ messages in thread
From: Bryce Harrington @ 2006-10-20 20:57 UTC (permalink / raw)
To: linux-kernel
We're seeing the following error building the 2.6.19-rc2-mm2 kernel on
ia64 (it builds ok on x86_64). 2.6.19-rc2-git4 builds ok.
CC [M] drivers/acpi/processor_throttling.o
arch/ia64/sn/kernel/setup.c: In function `sn_setup':
arch/ia64/sn/kernel/setup.c:470: error: `ia64_timestamp_clock' undeclared (first use in this function)
arch/ia64/sn/kernel/setup.c:470: error: (Each undeclared identifier is reported only once
arch/ia64/sn/kernel/setup.c:470: error: for each function it appears in.)
CC fs/ext2/namei.o
make[2]: *** [arch/ia64/sn/kernel/setup.o] Error 1
make[1]: *** [arch/ia64/sn/kernel] Error 2
make: *** [arch/ia64/sn] Error 2
make: *** Waiting for unfinished jobs....
Full logs:
http://crucible.osdl.org/runs/2688/logs/ita01/kernel.config.log
http://crucible.osdl.org/runs/2688/logs/ita01/kernel.make.log
Config file:
http://crucible.osdl.org/runs/2688/sysinfo/ita01.config
Bryce
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: 2.6.19-rc2-mm2 not building on ia64
2006-10-20 20:57 2.6.19-rc2-mm2 not building on ia64 Bryce Harrington
@ 2006-10-20 22:14 ` Jiri Kosina
2006-10-20 22:29 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2006-10-20 22:14 UTC (permalink / raw)
To: Bryce Harrington; +Cc: linux-kernel, Andrew Morton, Martin Peschke
On Fri, 20 Oct 2006, Bryce Harrington wrote:
> We're seeing the following error building the 2.6.19-rc2-mm2 kernel on
> ia64 (it builds ok on x86_64). 2.6.19-rc2-git4 builds ok.
> CC [M] drivers/acpi/processor_throttling.o
> arch/ia64/sn/kernel/setup.c: In function `sn_setup':
> arch/ia64/sn/kernel/setup.c:470: error: `ia64_timestamp_clock' undeclared (first use in this function)
> arch/ia64/sn/kernel/setup.c:470: error: (Each undeclared identifier is reported only once
> arch/ia64/sn/kernel/setup.c:470: error: for each function it appears in.)
> CC fs/ext2/namei.o
> make[2]: *** [arch/ia64/sn/kernel/setup.o] Error 1
> make[1]: *** [arch/ia64/sn/kernel] Error 2
> make: *** [arch/ia64/sn] Error 2
> make: *** Waiting for unfinished jobs....
(added relevant CCs)
This is caused by
statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch
I wonder how this could ever compile :)
Andrew, could you please apply this trivial on top of the original one?
[PATCH] IA64: Fix compile problem in arch/ia64/sn/setup.c
Rename forgotten occurence of ia64_printk_clock to ia64_timestamp_clock
Signed-off-by: Jiri Kosina <jikos@jikos.cz>
---
arch/ia64/sn/kernel/setup.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/ia64/sn/kernel/setup.c b/arch/ia64/sn/kernel/setup.c
index 911000a..d3cf595 100644
--- a/arch/ia64/sn/kernel/setup.c
+++ b/arch/ia64/sn/kernel/setup.c
@@ -65,7 +65,7 @@ extern void sn_timer_init(void);
extern unsigned long last_time_offset;
extern void (*ia64_mark_idle) (int);
extern void snidle(int);
-extern unsigned long long (*ia64_printk_clock)(void);
+extern unsigned long long (*ia64_timestamp_clock)(void);
unsigned long sn_rtc_cycles_per_second;
EXPORT_SYMBOL(sn_rtc_cycles_per_second);
--
Jiri Kosina
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: 2.6.19-rc2-mm2 not building on ia64
2006-10-20 22:14 ` Jiri Kosina
@ 2006-10-20 22:29 ` Andrew Morton
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2006-10-20 22:29 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Bryce Harrington, linux-kernel, Martin Peschke
On Sat, 21 Oct 2006 00:14:34 +0200 (CEST)
Jiri Kosina <jikos@jikos.cz> wrote:
> On Fri, 20 Oct 2006, Bryce Harrington wrote:
>
> > We're seeing the following error building the 2.6.19-rc2-mm2 kernel on
> > ia64 (it builds ok on x86_64). 2.6.19-rc2-git4 builds ok.
> > CC [M] drivers/acpi/processor_throttling.o
> > arch/ia64/sn/kernel/setup.c: In function `sn_setup':
> > arch/ia64/sn/kernel/setup.c:470: error: `ia64_timestamp_clock' undeclared (first use in this function)
> > arch/ia64/sn/kernel/setup.c:470: error: (Each undeclared identifier is reported only once
> > arch/ia64/sn/kernel/setup.c:470: error: for each function it appears in.)
> > CC fs/ext2/namei.o
> > make[2]: *** [arch/ia64/sn/kernel/setup.o] Error 1
> > make[1]: *** [arch/ia64/sn/kernel] Error 2
> > make: *** [arch/ia64/sn] Error 2
> > make: *** Waiting for unfinished jobs....
>
> (added relevant CCs)
>
> This is caused by
> statistics-infrastructure-make-printk_clock-a-generic-kernel-wide-nsec-resolution.patch
>
> I wonder how this could ever compile :)
grr. How many times do we have to tell how many people to not put extern
declarations in C files? This build error is a direct consequence of that
absolutely utterly basic programming mistake.
> Andrew, could you please apply this trivial on top of the original one?
If I had the energy I'd fix it for real, but I don't so I won't. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-10-20 22:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-20 20:57 2.6.19-rc2-mm2 not building on ia64 Bryce Harrington
2006-10-20 22:14 ` Jiri Kosina
2006-10-20 22:29 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox