public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Nigel Cunningham <ncunningham@linuxmail.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@osdl.org>,
	suspend2-devel <suspend2-devel@lists.suspend2.net>
Subject: Re: [linux-pm] [PATCH] Add include/linux/freezer.h and move definitions from	sched.h
Date: Sat, 21 Oct 2006 14:42:25 +0200	[thread overview]
Message-ID: <20061021124225.GA10892@elf.ucw.cz> (raw)
In-Reply-To: <1161433266.7644.7.camel@nigel.suspend2.net>

Hi!

> Move process freezing functions from include/linux/sched.h to freezer.h,
> so that modifications to the freezer or the kernel configuration don't
> require recompiling just about everything.

Well, I'm not sure if freezer changes often enough for this to
matter. ..

Patch is pretty much okay (provided it does not change any code)
"is it worth the change" is up-to Andrew.

> --- /dev/null
> +++ b/include/linux/freezer.h
> @@ -0,0 +1,84 @@
> +/* Freezer declarations */
> +

Needs copyright/GPL at least.

> +#ifdef CONFIG_PM
> +/*
> + * Check if a process has been frozen
> + */
> +static inline int frozen(struct task_struct *p)
> +{
> +	return p->flags & PF_FROZEN;
> +}

And switch it to kerneldoc while you are at it...

								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2006-10-23 12:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-10-21 12:21 [PATCH] Add include/linux/freezer.h and move definitions from sched.h Nigel Cunningham
2006-10-21 12:42 ` Pavel Machek [this message]
2006-10-21 13:41 ` Rafael J. Wysocki
2006-10-21 22:27   ` Nigel Cunningham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061021124225.GA10892@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@osdl.org \
    --cc=ncunningham@linuxmail.org \
    --cc=suspend2-devel@lists.suspend2.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox